You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/06/10 14:37:02 UTC

[jira] [Commented] (SLING-4777) Decouple the model provider from the actual validation service

    [ https://issues.apache.org/jira/browse/SLING-4777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14580462#comment-14580462 ] 

ASF GitHub Bot commented on SLING-4777:
---------------------------------------

GitHub user kwin opened a pull request:

    https://github.com/apache/sling/pull/95

    SLING-4777 separate model provider

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kwin/sling SLING-4777-modelprovider

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/sling/pull/95.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #95
    
----
commit 4772a2da7a901477a0eaafeda39abb913536ded8
Author: Konrad Windszus <ko...@netcentric.biz>
Date:   2015-06-05T14:54:11Z

    SLING-4777 first draft of a refactoring (not yet adjusted the test
    cases)

commit 3f8d238febda257d827be8aac089cccb90e5d779
Author: Konrad Windszus <ko...@netcentric.biz>
Date:   2015-06-05T16:24:53Z

    SLING-4377 WIP version of the tests

commit 5da1b4c54f1926b9c1363dfd6234f530accc66a5
Author: Konrad Windszus <ko...@netcentric.biz>
Date:   2015-06-08T12:30:10Z

    SLING-4777, further separate validation model from JCR

commit 5d30ef238e65b6b26bb815afbf6f26b000ff1e41
Author: Konrad Windszus <ko...@netcentric.biz>
Date:   2015-06-09T14:05:31Z

    SLING-4777 make project build again
    some test cases still missing

commit 958c17ea06dd3df90de7228cbae19e8d2e59903e
Author: Konrad Windszus <ko...@netcentric.biz>
Date:   2015-06-09T15:02:44Z

    SLING-4777 fix JSR305 annotations

commit 948711b5b49f4312ce1fe2b420009f211ec8f49b
Author: Konrad Windszus <ko...@netcentric.biz>
Date:   2015-06-10T12:34:55Z

    SLING-4777 fix all test cases, some more refactoring of the API

----


> Decouple the model provider from the actual validation service
> --------------------------------------------------------------
>
>                 Key: SLING-4777
>                 URL: https://issues.apache.org/jira/browse/SLING-4777
>             Project: Sling
>          Issue Type: Improvement
>            Reporter: Konrad Windszus
>            Assignee: Konrad Windszus
>             Fix For: Validation 1.0.0
>
>
> As being mentioned in SLING-4027, it would be good to completely decouple the model providing capabilities from the actual validation, as that would
> a) make the codebase cleaner (and would ease testing)
> b) allow to plug-in other services which provide models (e.g. based on annotations on some files)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)