You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2022/05/15 12:06:02 UTC
svn commit: r1900924 - /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/FileSystemFontProvider.java
Author: tilman
Date: Sun May 15 12:06:01 2022
New Revision: 1900924
URL: http://svn.apache.org/viewvc?rev=1900924&view=rev
Log:
PDFBOX-4892: optimize, as suggested by Valery Bokov
Modified:
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/FileSystemFontProvider.java
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/FileSystemFontProvider.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/FileSystemFontProvider.java?rev=1900924&r1=1900923&r2=1900924&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/FileSystemFontProvider.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/FileSystemFontProvider.java Sun May 15 12:06:01 2022
@@ -396,10 +396,10 @@ final class FileSystemFontProvider exten
private File getDiskCacheFile()
{
String path = System.getProperty("pdfbox.fontcache");
- if (path == null || !new File(path).isDirectory() || !new File(path).canWrite())
+ if (isBadPath(path))
{
path = System.getProperty("user.home");
- if (path == null || !new File(path).isDirectory() || !new File(path).canWrite())
+ if (isBadPath(path))
{
path = System.getProperty("java.io.tmpdir");
}
@@ -407,6 +407,11 @@ final class FileSystemFontProvider exten
return new File(path, ".pdfbox.cache");
}
+ private static boolean isBadPath(String path)
+ {
+ return path == null || !new File(path).isDirectory() || !new File(path).canWrite();
+ }
+
/**
* Saves the font metadata cache to disk.
*/