[jira] [Commented] (BEAM-10792) ReadFromBigQuery fails with ValueProvider for table

["Kenneth Knowles (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-10792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17478129#comment-17478129 ] 

Kenneth Knowles commented on BEAM-10792:
----------------------------------------

It looks like the fix to BEAM-12514 (https://github.com/apache/beam/pull/15040) may also have fixed this. The line in question has been changed, and also some related stuff in {{_BigQuerySource}}. Can you confirm if this is still happening? Otherwise we could close this one. CC [~pabloem] or [~chutium].

> ReadFromBigQuery fails with ValueProvider for table
> ---------------------------------------------------
>
>                 Key: BEAM-10792
>                 URL: https://issues.apache.org/jira/browse/BEAM-10792
>             Project: Beam
>          Issue Type: Bug
>          Components: io-py-gcp, sdk-py-core
>    Affects Versions: 2.23.0
>            Reporter: Michael Ballou
>            Priority: P3
>              Labels: bigquery, gcp, io, python
>
> 2 errors are present:
> 1. ReadFromBigQuery passing a ValueProvider for the table param gets this error:
> '_CustomBigQuerySource' object has no attribute 'dataset'
> File "./lib/python3.7/site-packages/apache_beam/io/gcp/bigquery.py", line 656, in estimate_size self.table_reference.get(), self.dataset, self.project)
> There are a 2 places where self.dataset are referenced, but it is never set to any value in the CustomBigQuerySource class.  This should be set __init__() method.
> 2. _export_files references table_ref as a str before checking if its a ValueProvider.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)