You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Alexander Shigin (JIRA)" <ji...@apache.org> on 2008/08/02 19:47:44 UTC

[jira] Created: (THRIFT-105) make a thrift_spec for a structures with negative tags

make a thrift_spec for a structures with negative tags
------------------------------------------------------

                 Key: THRIFT-105
                 URL: https://issues.apache.org/jira/browse/THRIFT-105
             Project: Thrift
          Issue Type: Improvement
          Components: Compiler (Python), Library (Python), Test Suite
            Reporter: Alexander Shigin
            Assignee: Alexander Shigin


The patch introduces thrift_offset variable for a python thrift structures. 

The change allows to use fastbinary module for structures with negative tags.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-105) make a thrift_spec for a structures with negative tags

Posted by "Alexander Shigin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexander Shigin updated THRIFT-105:
------------------------------------

    Attachment: thrift-python-offset-v5.diff

Ben, thank you for a review. I've change the patch to use INTERN_STRING.

But I don't understand that do you mean by 'validate that "offset" is valid'. Do you mean to check if tag of thrift_spec is equal to primary one?

> make a thrift_spec for a structures with negative tags
> ------------------------------------------------------
>
>                 Key: THRIFT-105
>                 URL: https://issues.apache.org/jira/browse/THRIFT-105
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (Python), Library (Python), Test Suite
>            Reporter: Alexander Shigin
>            Assignee: Alexander Shigin
>         Attachments: thrift-python-offset-v2.patch, thrift-python-offset-v3.patch, thrift-python-offset-v4.diff, thrift-python-offset-v5.diff, thrift-python-offset.patch
>
>
> The patch introduces thrift_offset variable for a python thrift structures. 
> The change allows to use fastbinary module for structures with negative tags.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-105) make a thrift_spec for a structures with negative tags

Posted by "Alexander Shigin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679731#action_12679731 ] 

Alexander Shigin commented on THRIFT-105:
-----------------------------------------

I'm sorry, but i haven't time to look at Esteve patch. I hope I'll check one in two days.

> make a thrift_spec for a structures with negative tags
> ------------------------------------------------------
>
>                 Key: THRIFT-105
>                 URL: https://issues.apache.org/jira/browse/THRIFT-105
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (Python), Library (Python), Test Suite
>            Reporter: Alexander Shigin
>            Assignee: Alexander Shigin
>         Attachments: thrift-python-offset-v2.patch, thrift-python-offset-v3.patch, thrift-python-offset.patch
>
>
> The patch introduces thrift_offset variable for a python thrift structures. 
> The change allows to use fastbinary module for structures with negative tags.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-105) make a thrift_spec for a structures with negative tags

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623769#action_12623769 ] 

David Reiss commented on THRIFT-105:
------------------------------------

I'd prefer if Ben could review this since he wrote the original, but I have a few comments.

Does this test code actually test the behavior of the patch?
What was wrong with self.__class__ ?
PyInt_AsLong returns a long, not a ssize_t.


> make a thrift_spec for a structures with negative tags
> ------------------------------------------------------
>
>                 Key: THRIFT-105
>                 URL: https://issues.apache.org/jira/browse/THRIFT-105
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (Python), Library (Python), Test Suite
>            Reporter: Alexander Shigin
>            Assignee: Alexander Shigin
>         Attachments: thrift-python-offset.patch
>
>
> The patch introduces thrift_offset variable for a python thrift structures. 
> The change allows to use fastbinary module for structures with negative tags.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-105) make a thrift_spec for a structures with negative tags

Posted by "Alexander Shigin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexander Shigin updated THRIFT-105:
------------------------------------

    Attachment: thrift-python-offset-v6.diff

Tag extra check was added.

> make a thrift_spec for a structures with negative tags
> ------------------------------------------------------
>
>                 Key: THRIFT-105
>                 URL: https://issues.apache.org/jira/browse/THRIFT-105
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (Python), Library (Python), Test Suite
>            Reporter: Alexander Shigin
>            Assignee: Alexander Shigin
>         Attachments: thrift-python-offset-v2.patch, thrift-python-offset-v3.patch, thrift-python-offset-v4.diff, thrift-python-offset-v5.diff, thrift-python-offset-v6.diff, thrift-python-offset.patch
>
>
> The patch introduces thrift_offset variable for a python thrift structures. 
> The change allows to use fastbinary module for structures with negative tags.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-105) make a thrift_spec for a structures with negative tags

Posted by "Alexander Shigin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexander Shigin updated THRIFT-105:
------------------------------------

    Attachment: thrift-python-offset-v2.patch

Oh, I've forgot to attach the fixed version. Please review.

> make a thrift_spec for a structures with negative tags
> ------------------------------------------------------
>
>                 Key: THRIFT-105
>                 URL: https://issues.apache.org/jira/browse/THRIFT-105
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (Python), Library (Python), Test Suite
>            Reporter: Alexander Shigin
>            Assignee: Alexander Shigin
>         Attachments: thrift-python-offset-v2.patch, thrift-python-offset.patch
>
>
> The patch introduces thrift_offset variable for a python thrift structures. 
> The change allows to use fastbinary module for structures with negative tags.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-105) make a thrift_spec for a structures with negative tags

Posted by "Alexander Shigin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624853#action_12624853 ] 

Alexander Shigin commented on THRIFT-105:
-----------------------------------------

It's all ok with self.__class__, I've noticed a little speed up (about 0.2%) using ClassName instead of self.__class__.

I'll fix the seconf issue.

> make a thrift_spec for a structures with negative tags
> ------------------------------------------------------
>
>                 Key: THRIFT-105
>                 URL: https://issues.apache.org/jira/browse/THRIFT-105
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (Python), Library (Python), Test Suite
>            Reporter: Alexander Shigin
>            Assignee: Alexander Shigin
>         Attachments: thrift-python-offset.patch
>
>
> The patch introduces thrift_offset variable for a python thrift structures. 
> The change allows to use fastbinary module for structures with negative tags.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-105) make a thrift_spec for a structures with negative tags

Posted by "Kevin Clark (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679737#action_12679737 ] 

Kevin Clark commented on THRIFT-105:
------------------------------------

Sure, just checking in.

> make a thrift_spec for a structures with negative tags
> ------------------------------------------------------
>
>                 Key: THRIFT-105
>                 URL: https://issues.apache.org/jira/browse/THRIFT-105
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (Python), Library (Python), Test Suite
>            Reporter: Alexander Shigin
>            Assignee: Alexander Shigin
>         Attachments: thrift-python-offset-v2.patch, thrift-python-offset-v3.patch, thrift-python-offset.patch
>
>
> The patch introduces thrift_offset variable for a python thrift structures. 
> The change allows to use fastbinary module for structures with negative tags.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-105) make a thrift_spec for a structures with negative tags

Posted by "Alexander Shigin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexander Shigin updated THRIFT-105:
------------------------------------

    Attachment: thrift-python-offset-v7.diff

Improve compatibility with previous generated files.

It strange, but it seems that PyObject_GetAttr throws an exception if can't found attribute.

> make a thrift_spec for a structures with negative tags
> ------------------------------------------------------
>
>                 Key: THRIFT-105
>                 URL: https://issues.apache.org/jira/browse/THRIFT-105
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (Python), Library (Python), Test Suite
>            Reporter: Alexander Shigin
>            Assignee: Alexander Shigin
>         Attachments: thrift-python-offset-v2.patch, thrift-python-offset-v3.patch, thrift-python-offset-v4.diff, thrift-python-offset-v5.diff, thrift-python-offset-v6.diff, thrift-python-offset-v7.diff, thrift-python-offset.patch
>
>
> The patch introduces thrift_offset variable for a python thrift structures. 
> The change allows to use fastbinary module for structures with negative tags.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-105) make a thrift_spec for a structures with negative tags

Posted by "Alexander Shigin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680123#action_12680123 ] 

Alexander Shigin commented on THRIFT-105:
-----------------------------------------

Esteve, I've review your patch. I'm biassed, but I prefer my patch :).

I don't get the idea of thrift_limits. In the original version of fast binary protocol the boundaries are checked by length of thrift_spec. I've choose the same way. And your patch has unnecessary old check with length of thrift_spec.

The second issue with your patch is unnatural order of fields in thrift_spec. The David's idea is briliant, but I prefer to duplicate default values in thrift_spec and __init__ to increase readability. Still the THRIFT-105 + THRIFT-339 patchs smaller than your patch.

> make a thrift_spec for a structures with negative tags
> ------------------------------------------------------
>
>                 Key: THRIFT-105
>                 URL: https://issues.apache.org/jira/browse/THRIFT-105
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (Python), Library (Python), Test Suite
>            Reporter: Alexander Shigin
>            Assignee: Alexander Shigin
>         Attachments: thrift-python-offset-v2.patch, thrift-python-offset-v3.patch, thrift-python-offset.patch
>
>
> The patch introduces thrift_offset variable for a python thrift structures. 
> The change allows to use fastbinary module for structures with negative tags.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-105) make a thrift_spec for a structures with negative tags

Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679218#action_12679218 ] 

Esteve Fernandez commented on THRIFT-105:
-----------------------------------------

Actually it's my fault for not linking both issues, THRIFT-105 is older than THRIFT-339, and as such it should haven taken precedence over the latter.

Sadly, the patch for THRIFT-339 can't be split easily because both issues are too closely related. Anyway, what are your thoughts between the two approaches? I think the patch for THRIFT-339 is a bit more robust, as it checks boundaries, but your patch is cleaner and less invasive.

Given that constructors have changed and the mega-patch for Twisted has been committed, your patch no longer applies cleanly :-( I'll try to update it to the current code base, so we can compare it against THRIFT-339 and agree on the one that we like most.

> make a thrift_spec for a structures with negative tags
> ------------------------------------------------------
>
>                 Key: THRIFT-105
>                 URL: https://issues.apache.org/jira/browse/THRIFT-105
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (Python), Library (Python), Test Suite
>            Reporter: Alexander Shigin
>            Assignee: Alexander Shigin
>         Attachments: thrift-python-offset-v2.patch, thrift-python-offset.patch
>
>
> The patch introduces thrift_offset variable for a python thrift structures. 
> The change allows to use fastbinary module for structures with negative tags.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-105) make a thrift_spec for a structures with negative tags

Posted by "Ben Maurer (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680237#action_12680237 ] 

Ben Maurer commented on THRIFT-105:
-----------------------------------

- Should use INTERN_STRING to speed field lookup
- should probably validate that "offset" is valid to protect against memory errors

> make a thrift_spec for a structures with negative tags
> ------------------------------------------------------
>
>                 Key: THRIFT-105
>                 URL: https://issues.apache.org/jira/browse/THRIFT-105
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (Python), Library (Python), Test Suite
>            Reporter: Alexander Shigin
>            Assignee: Alexander Shigin
>         Attachments: thrift-python-offset-v2.patch, thrift-python-offset-v3.patch, thrift-python-offset-v4.diff, thrift-python-offset.patch
>
>
> The patch introduces thrift_offset variable for a python thrift structures. 
> The change allows to use fastbinary module for structures with negative tags.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-105) make a thrift_spec for a structures with negative tags

Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678746#action_12678746 ] 

Esteve Fernandez commented on THRIFT-105:
-----------------------------------------

I think THRIFT-339 is similar to this one. Your patch looks a bit simpler (a good thing!), but the other one checks whether a tag is in a specified range. It needs an extra variable too, though. We could work together on merging both patches and fix negative tags once for all! :-)

> make a thrift_spec for a structures with negative tags
> ------------------------------------------------------
>
>                 Key: THRIFT-105
>                 URL: https://issues.apache.org/jira/browse/THRIFT-105
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (Python), Library (Python), Test Suite
>            Reporter: Alexander Shigin
>            Assignee: Alexander Shigin
>         Attachments: thrift-python-offset-v2.patch, thrift-python-offset.patch
>
>
> The patch introduces thrift_offset variable for a python thrift structures. 
> The change allows to use fastbinary module for structures with negative tags.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-105) make a thrift_spec for a structures with negative tags

Posted by "Alexander Shigin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexander Shigin updated THRIFT-105:
------------------------------------

    Attachment: thrift-python-offset-v4.diff

testInsanity uses new-style initialization (THRIFT-242).

> make a thrift_spec for a structures with negative tags
> ------------------------------------------------------
>
>                 Key: THRIFT-105
>                 URL: https://issues.apache.org/jira/browse/THRIFT-105
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (Python), Library (Python), Test Suite
>            Reporter: Alexander Shigin
>            Assignee: Alexander Shigin
>         Attachments: thrift-python-offset-v2.patch, thrift-python-offset-v3.patch, thrift-python-offset-v4.diff, thrift-python-offset.patch
>
>
> The patch introduces thrift_offset variable for a python thrift structures. 
> The change allows to use fastbinary module for structures with negative tags.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-105) make a thrift_spec for a structures with negative tags

Posted by "Alexander Shigin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678892#action_12678892 ] 

Alexander Shigin commented on THRIFT-105:
-----------------------------------------

Esteve, I've missed your patch, sorry. Can you split your patch into two: patch for this issue and patch for THRIFT-339?

> make a thrift_spec for a structures with negative tags
> ------------------------------------------------------
>
>                 Key: THRIFT-105
>                 URL: https://issues.apache.org/jira/browse/THRIFT-105
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (Python), Library (Python), Test Suite
>            Reporter: Alexander Shigin
>            Assignee: Alexander Shigin
>         Attachments: thrift-python-offset-v2.patch, thrift-python-offset.patch
>
>
> The patch introduces thrift_offset variable for a python thrift structures. 
> The change allows to use fastbinary module for structures with negative tags.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-105) make a thrift_spec for a structures with negative tags

Posted by "Alexander Shigin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678645#action_12678645 ] 

Alexander Shigin commented on THRIFT-105:
-----------------------------------------

Can someone review the patch. Please!

> make a thrift_spec for a structures with negative tags
> ------------------------------------------------------
>
>                 Key: THRIFT-105
>                 URL: https://issues.apache.org/jira/browse/THRIFT-105
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (Python), Library (Python), Test Suite
>            Reporter: Alexander Shigin
>            Assignee: Alexander Shigin
>         Attachments: thrift-python-offset-v2.patch, thrift-python-offset.patch
>
>
> The patch introduces thrift_offset variable for a python thrift structures. 
> The change allows to use fastbinary module for structures with negative tags.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-105) make a thrift_spec for a structures with negative tags

Posted by "Kevin Clark (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679723#action_12679723 ] 

Kevin Clark commented on THRIFT-105:
------------------------------------

Is this good to go?

> make a thrift_spec for a structures with negative tags
> ------------------------------------------------------
>
>                 Key: THRIFT-105
>                 URL: https://issues.apache.org/jira/browse/THRIFT-105
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (Python), Library (Python), Test Suite
>            Reporter: Alexander Shigin
>            Assignee: Alexander Shigin
>         Attachments: thrift-python-offset-v2.patch, thrift-python-offset-v3.patch, thrift-python-offset.patch
>
>
> The patch introduces thrift_offset variable for a python thrift structures. 
> The change allows to use fastbinary module for structures with negative tags.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-105) make a thrift_spec for a structures with negative tags

Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679736#action_12679736 ] 

Esteve Fernandez commented on THRIFT-105:
-----------------------------------------

I didn't modify your patch at all, I simply updated it to apply cleanly. It wasn't that hard, your patch was pretty clean :-) In any case, I won't be able to compare exhaustively both patches (this one vs THRIFT-339) until Monday. Could we put this issue on hold until then?

> make a thrift_spec for a structures with negative tags
> ------------------------------------------------------
>
>                 Key: THRIFT-105
>                 URL: https://issues.apache.org/jira/browse/THRIFT-105
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (Python), Library (Python), Test Suite
>            Reporter: Alexander Shigin
>            Assignee: Alexander Shigin
>         Attachments: thrift-python-offset-v2.patch, thrift-python-offset-v3.patch, thrift-python-offset.patch
>
>
> The patch introduces thrift_offset variable for a python thrift structures. 
> The change allows to use fastbinary module for structures with negative tags.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-105) make a thrift_spec for a structures with negative tags

Posted by "Alexander Shigin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexander Shigin updated THRIFT-105:
------------------------------------

    Attachment: thrift-python-offset.patch

pri/shigin/py-newlib branch

The patch includes a benchmark for python thrift serialization. The benchmark doesn't show a significant difference with and without a patch. The difference is below 2%.

> make a thrift_spec for a structures with negative tags
> ------------------------------------------------------
>
>                 Key: THRIFT-105
>                 URL: https://issues.apache.org/jira/browse/THRIFT-105
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (Python), Library (Python), Test Suite
>            Reporter: Alexander Shigin
>            Assignee: Alexander Shigin
>         Attachments: thrift-python-offset.patch
>
>
> The patch introduces thrift_offset variable for a python thrift structures. 
> The change allows to use fastbinary module for structures with negative tags.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-105) make a thrift_spec for a structures with negative tags

Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Esteve Fernandez updated THRIFT-105:
------------------------------------

    Attachment: thrift-python-offset-v3.patch

Updated patch against current trunk (r750667).

> make a thrift_spec for a structures with negative tags
> ------------------------------------------------------
>
>                 Key: THRIFT-105
>                 URL: https://issues.apache.org/jira/browse/THRIFT-105
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (Python), Library (Python), Test Suite
>            Reporter: Alexander Shigin
>            Assignee: Alexander Shigin
>         Attachments: thrift-python-offset-v2.patch, thrift-python-offset-v3.patch, thrift-python-offset.patch
>
>
> The patch introduces thrift_offset variable for a python thrift structures. 
> The change allows to use fastbinary module for structures with negative tags.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.