[GitHub] [incubator-mxnet] DickJC123 edited a comment on issue #16462: Fix flakey pylint CI failures

[GitBox <gi...@apache.org>]

DickJC123 edited a comment on issue #16462: Fix flakey pylint CI failures
URL: https://github.com/apache/incubator-mxnet/pull/16462#issuecomment-541382236
 
 
   My 2nd commit successfully eliminated the E0402 error triggered by numpy_op_signature.py.
   Since @reminisce, @stu1130 and @larroy were involved in prior tweeking this file for this issue, I invite any of them to weigh-in on my fix, which basically involved massaging the syntax of the code without really changing the functionality.
   
   So it seems that the jobs==1 setting generates many more errors than jobs==N.  For our codebase, it introduced **too-many-lines**, **duplicate-code** and **cyclic-import** errors.  I could see how the **duplicate-code** and **cyclic-import** errors might be turned off with jobs=N, since one really needs a view of the entire codebase to report all errors correctly.  I'm not sure why suddenly too-many-lines errors are cropping up, but it isn't in the scope of this PR to fix our in-some-cases massive modules.
   
   Bottom line: with my third commit, I've disabled too-many-lines, duplicate-code and cyclic-import, and now pylint --jobs=1 is passing.  I'll trigger the CI again to gain some confidence in the solution.
   
   Removing WIP.  Please review.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services