[GitHub] [kafka] lianetm commented on a diff in pull request #13605: KAFKA-14950: implement assign() and assignment()

["lianetm (via GitHub)" <gi...@apache.org>]

lianetm commented on code in PR #13605:
URL: https://github.com/apache/kafka/pull/13605#discussion_r1181594901


##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumerTest.java:
##########
@@ -157,9 +161,39 @@ public void testCommitted() {
     }
 
     @Test
-    public void testUnimplementedException() {
+    public void testAssign() {
+        consumer = spy(newConsumer(time, new StringDeserializer(), new StringDeserializer()));
+        consumer.assign(singleton(new TopicPartition("foo", 3)));
+        assertTrue(consumer.subscription().isEmpty());
+        assertTrue(consumer.assignment().isEmpty());

Review Comment:
   Shouldn't it be expected to have the foo-3 assignment here? (assigned from user in the subscriptionState as a result of the previous `consumer.assign`)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org