[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1718: [CELEBORN-797] Decrease writeTime metric sampling frequency to improve perf

["pan3793 (via GitHub)" <gi...@apache.org>]

pan3793 commented on code in PR #1718:
URL: https://github.com/apache/incubator-celeborn/pull/1718#discussion_r1263560401


##########
client-spark/spark-3/src/main/java/org/apache/spark/shuffle/celeborn/HashBasedShuffleWriter.java:
##########
@@ -391,8 +381,10 @@ private int getOrUpdateOffset(int partitionId, int serializedRecordSize)
 
   private void flushSendBuffer(int partitionId, byte[] buffer, int size)
       throws IOException, InterruptedException {
+    long pushStartTime = System.nanoTime();
     logger.debug("Flush buffer, size {}.", size);

Review Comment:
   format size?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org