Re: [PR] [expr](exec) Aggregation operator uses the new expr interface. [doris]

["HappenLee (via GitHub)" <gi...@apache.org>]

HappenLee commented on code in PR #58297:
URL: https://github.com/apache/doris/pull/58297#discussion_r2575490410


##########
be/src/pipeline/dependency.cpp:
##########
@@ -253,20 +253,48 @@ void AggSharedState::build_limit_heap(size_t hash_table_size) {
     limit_columns_min = limit_heap.top()._row_id;
 }
 
-bool AggSharedState::do_limit_filter(vectorized::Block* block, size_t num_rows,
-                                     const std::vector<int>* key_locs) {
+bool AggSharedState::do_limit_filter(vectorized::Block* block, size_t num_rows) {

Review Comment:
   only keep one interface, not keep the block interface



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org