[jira] [Commented] (LUCENE-3875) ValueSourceFilter

["Chris Male (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-3875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245980#comment-13245980 ] 

Chris Male commented on LUCENE-3875:
------------------------------------

Hey Gregg,

Did a quick review and it looks great.  I'm happy to commit this when its ready.

The general trend is to use FixedBitSet instead of OpenBitSet in situations like this where we know the maximum size.  Could you make the change?  Also in the tests, could we move the createIndex and destroyIndex into setUp() and tearDown() respectively?
                
> ValueSourceFilter
> -----------------
>
>                 Key: LUCENE-3875
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3875
>             Project: Lucene - Java
>          Issue Type: New Feature
>            Reporter: Andrew Morrison
>         Attachments: LUCENE-3875-1.patch, LUCENE-3875.patch
>
>
> A ValueSourceFilter is a filter that takes a ValueSource and a threshold value, filtering out documents for which their value returned by the ValueSource is below the threshold.
> We use the ValueSourceFilter for filtering documents based on their value in an ExternalFileField.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org