You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/07/29 02:12:56 UTC

[GitHub] [apisix-dashboard] Baoyuantop commented on a diff in pull request #2502: feat: Adding batch deletion function for routing pages

Baoyuantop commented on code in PR #2502:
URL: https://github.com/apache/apisix-dashboard/pull/2502#discussion_r932809548


##########
web/src/pages/Route/List.tsx:
##########
@@ -542,6 +545,27 @@ const Page: React.FC = () => {
         actionRef={ref}
         rowKey="id"
         columns={columns}
+        rowSelection={rowSelection}
+        tableAlertRender={() => (
+          <Space size={24}>
+            <span>
+            {formatMessage({ id: 'page.route.chosen' })} {selectedRowKeys.length} {formatMessage({ id: 'page.route.item' })}
+            </span>
+          </Space>
+        )}
+        tableAlertOptionRender={() => {
+          return (
+            <Space size={16}>
+              <Button

Review Comment:
   A small suggestion, for the delete type of button we tend to use red to keep the style consistent, for this delete all the dangerous operations, it is best to add a pop-up window to confirm the second



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org