You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by ca...@apache.org on 2021/01/08 15:44:00 UTC

[royale-asjs] branch develop updated: jewel-ResponsiveVisibility: fix regression

This is an automated email from the ASF dual-hosted git repository.

carlosrovira pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git


The following commit(s) were added to refs/heads/develop by this push:
     new 1249611  jewel-ResponsiveVisibility: fix regression
1249611 is described below

commit 12496110db8cb82335511248bd17b62e00d66f84
Author: Carlos Rovira <ca...@apache.org>
AuthorDate: Fri Jan 8 16:43:43 2021 +0100

    jewel-ResponsiveVisibility: fix regression
---
 .../jewel/beads/layouts/ResponsiveVisibility.as    | 59 +++++++++-------------
 1 file changed, 23 insertions(+), 36 deletions(-)

diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/layouts/ResponsiveVisibility.as b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/layouts/ResponsiveVisibility.as
index 9db7973..8fcbed6 100644
--- a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/layouts/ResponsiveVisibility.as
+++ b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/layouts/ResponsiveVisibility.as
@@ -46,7 +46,7 @@ package org.apache.royale.jewel.beads.layouts
 		{
 		}
 
-		private var _phoneVisible:Boolean;
+		private var _phoneVisible:Boolean = true;
 		/**
 		 *  Makes the component to be visible or hidden in phone size
 		 *  Uses "visible-phone" and "hidden-phone" effect selectors.
@@ -75,7 +75,7 @@ package org.apache.royale.jewel.beads.layouts
 			}
 		}
 
-		private var _tabletVisible:Boolean;
+		private var _tabletVisible:Boolean = true;
 		/**
 		 *  Makes the component to be visible or hidden in phone size
 		 *  Uses "visible-tablet" and "hidden-tablet" effect selectors.
@@ -104,7 +104,7 @@ package org.apache.royale.jewel.beads.layouts
 			}
 		}
 
-		private var _desktopVisible:Boolean;
+		private var _desktopVisible:Boolean = true;
 		/**
 		 *  Makes the component to be visible or hidden in phone size
 		 *  Uses "visible-desktop" and "hidden-desktop" effect selectors.
@@ -133,7 +133,7 @@ package org.apache.royale.jewel.beads.layouts
 			}
 		}
 		
-		private var _wideScreenVisible:Boolean;
+		private var _wideScreenVisible:Boolean = true;
 		/**
 		 *  Makes the component to be visible or hidden in phone size
 		 *  Uses "visible-widescreen" and "hidden-widescreen" effect selectors.
@@ -185,38 +185,25 @@ package org.apache.royale.jewel.beads.layouts
 			var host:IClassSelectorListSupport = _strand as IClassSelectorListSupport;
 			if (host)
             {
-				if(phoneVisible != null)
-				{
-					if(phoneVisible)
-						host.replaceClass("hidden-phone", "visible-phone");
-					else
-						host.replaceClass("visible-phone", "hidden-phone");
-				}
-
-				if(tabletVisible != null)
-				{
-					if(tabletVisible)
-						host.replaceClass("hidden-tablet", "visible-tablet");
-					else
-						host.replaceClass("visible-tablet", "hidden-tablet");
-
-				}
-
-				if(desktopVisible != null)
-				{
-					if(desktopVisible)
-						host.replaceClass("hidden-desktop", "visible-desktop");
-					else
-						host.replaceClass("visible-desktop", "hidden-desktop");
-				}
-
-				if(wideScreenVisible != null)
-				{
-					if(wideScreenVisible)
-						host.replaceClass("hidden-widescreen", "visible-widescreen");
-					else
-						host.replaceClass("visible-widescreen", "hidden-widescreen");
-				}
+				if(phoneVisible)
+					host.replaceClass("hidden-phone", "visible-phone");
+				else
+					host.replaceClass("visible-phone", "hidden-phone");
+
+				if(tabletVisible)
+					host.replaceClass("hidden-tablet", "visible-tablet");
+				else
+					host.replaceClass("visible-tablet", "hidden-tablet");
+
+				if(desktopVisible)
+					host.replaceClass("hidden-desktop", "visible-desktop");
+				else
+					host.replaceClass("visible-desktop", "hidden-desktop");
+
+				if(wideScreenVisible)
+					host.replaceClass("hidden-widescreen", "visible-widescreen");
+				else
+					host.replaceClass("visible-widescreen", "hidden-widescreen");
             }
 		}
 	}