You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "zeroshade (via GitHub)" <gi...@apache.org> on 2023/04/25 17:20:14 UTC
[GitHub] [arrow] zeroshade opened a new pull request, #35338: GH-35337: [Go] ASAN tests fail with Go1.20+
zeroshade opened a new pull request, #35338:
URL: https://github.com/apache/arrow/pull/35338
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
Fixing crashes when using ASAN to run unit tests under Go1.20+, requires features that were only added in go1.20. For versions <=go.19, the code remains unchanged.
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
The only way to properly test these changes would be to increase the matrix of jobs for Go, but we already have quite a few jobs. @assignUser Do you have any issues with adding go1.20 (or maybe just telling it to use "latest") as another set of Go jobs to the GHA config?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35338: GH-35337: [Go] ASAN tests fail with Go1.20+
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35338:
URL: https://github.com/apache/arrow/pull/35338#issuecomment-1522150359
:warning: GitHub issue #35337 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35338: GH-35337: [Go] ASAN tests fail with Go1.20+
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35338:
URL: https://github.com/apache/arrow/pull/35338#issuecomment-1527033292
Benchmark runs are scheduled for baseline = c95980f4bee406504a68ff3a3d39cd86c1d97ec0 and contender = 06d49ee63e26ba685e7da78064e20dd96610e1e1. 06d49ee63e26ba685e7da78064e20dd96610e1e1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/cab56c5c4fbe4dd98c8121c94943a6e3...7a049f5655c94ae8a3f1167c11e30a66/)
[Finished :arrow_down:7.2% :arrow_up:1.48%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/94d46de895c34b41b7bb21eec3bf0edf...c6e8fa6f3fe1494dbc33dff004d6e62b/)
[Finished :arrow_down:2.55% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/841b2f97567546a78bdcc7e03bb2eeec...4e363fa538d644578a82ce3b5952a19f/)
[Finished :arrow_down:0.39% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/f63a70036a6a46cdac66dfd856faed44...0d28544b9b3d4579bb8b06e37ff7b9d2/)
Buildkite builds:
[Finished] [`06d49ee6` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2793)
[Finished] [`06d49ee6` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2827)
[Finished] [`06d49ee6` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2791)
[Finished] [`06d49ee6` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2818)
[Finished] [`c95980f4` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2792)
[Finished] [`c95980f4` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2826)
[Finished] [`c95980f4` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2790)
[Finished] [`c95980f4` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2817)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #35338: GH-35337: [Go] ASAN tests fail with Go1.20+
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #35338:
URL: https://github.com/apache/arrow/pull/35338#issuecomment-1522365718
@github-actions crossbow submit "*go-1*"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #35338: GH-35337: [Go] ASAN tests fail with Go1.20+
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #35338:
URL: https://github.com/apache/arrow/pull/35338#issuecomment-1526897070
@github-actions crossbow submit test-debian-11-go-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #35338: GH-35337: [Go] ASAN tests fail with Go1.20+
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #35338:
URL: https://github.com/apache/arrow/pull/35338#issuecomment-1522312237
@github-actions crossbow submit "*go-1*"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on a diff in pull request #35338: GH-35337: [Go] ASAN tests fail with Go1.20+
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on code in PR #35338:
URL: https://github.com/apache/arrow/pull/35338#discussion_r1177984169
##########
go/internal/hashing/hash_string.go:
##########
@@ -0,0 +1,30 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+//go:build !go1.20
Review Comment:
the Go build constraints syntax revolves around the existence of "tags" and doesn't support `<` or `>` operators, it only supports parens, `&`, `!`, and `|`. That said, all go version tags are set for all subsequent versions. So basically `!go1.20` == `<go1.20` and `go1.20` == `>=go1.20`.
So this will do the correct thing and will also exclude go1.21 and later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on a diff in pull request #35338: GH-35337: [Go] ASAN tests fail with Go1.20+
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on code in PR #35338:
URL: https://github.com/apache/arrow/pull/35338#discussion_r1177987580
##########
go/go.mod:
##########
@@ -16,7 +16,7 @@
module github.com/apache/arrow/go/v12
-go 1.18
+go 1.20
Review Comment:
the version in the go.mod file isn't a minimum but a "recommended" version. The problem is that you cannot use anything in the module that is only introduced in a version *after* the one specified in the go.mod. Since I'm using `unsafe.StringData` which was only introduced in go1.20, I need to bump the go.mod version in order to use it. Otherwise it won't compile, even though it's behind a build constraint.
That said, this still won't prevent earlier versions of go from compiling the module, it'll just print an advisory note if there's a compile error saying that the module "recommends" go1.20
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35338: GH-35337: [Go] ASAN tests fail with Go1.20+
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35338:
URL: https://github.com/apache/arrow/pull/35338#issuecomment-1527037256
['Python', 'R'] benchmarks have high level of regressions.
[test-mac-arm](https://conbench.ursa.dev/compare/runs/94d46de895c34b41b7bb21eec3bf0edf...c6e8fa6f3fe1494dbc33dff004d6e62b/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35338: GH-35337: [Go] ASAN tests fail with Go1.20+
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35338:
URL: https://github.com/apache/arrow/pull/35338#issuecomment-1522270115
Revision: f8437e3107a6a70857098d7b534ca924dda454c7
Submitted crossbow builds: [ursacomputing/crossbow @ actions-9e386221e4](https://github.com/ursacomputing/crossbow/branches/all?query=actions-9e386221e4)
|Task|Status|
|----|------|
|test-debian-11-go-1.17|[](https://github.com/ursacomputing/crossbow/runs/13017104147)|
|test-debian-11-go-1.20|[](https://github.com/ursacomputing/crossbow/runs/13017103249)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35338: GH-35337: [Go] ASAN tests fail with Go1.20+
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35338:
URL: https://github.com/apache/arrow/pull/35338#issuecomment-1522332642
Revision: d7dec51084478aefb94e21ec7786427f182af9b8
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1134939d99](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1134939d99)
|Task|Status|
|----|------|
|test-debian-11-go-1.17|[](https://github.com/ursacomputing/crossbow/runs/13018356235)|
|test-debian-11-go-1.20|[](https://github.com/ursacomputing/crossbow/runs/13018356874)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #35338: GH-35337: [Go] ASAN tests fail with Go1.20+
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #35338:
URL: https://github.com/apache/arrow/pull/35338#issuecomment-1522299246
@github-actions crossbow submit "*go-1*"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #35338: GH-35337: [Go] ASAN tests fail with Go1.20+
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #35338:
URL: https://github.com/apache/arrow/pull/35338#issuecomment-1522416759
@assignUser @raulcd this is *finally* good for a review as it finally succeeds all the small things that @assignUser found when testing using go1.20.
None of this should be considered a blocker for the v12 release though I don't think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a diff in pull request #35338: GH-35337: [Go] ASAN tests fail with Go1.20+
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #35338:
URL: https://github.com/apache/arrow/pull/35338#discussion_r1178528476
##########
go/go.mod:
##########
@@ -16,7 +16,7 @@
module github.com/apache/arrow/go/v12
-go 1.18
+go 1.20
Review Comment:
Ah, cool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35338: GH-35337: [Go] ASAN tests fail with Go1.20+
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35338:
URL: https://github.com/apache/arrow/pull/35338#issuecomment-1526899446
Revision: c02ccfadfea2751cf9cc17dc4bea363bfb62c566
Submitted crossbow builds: [ursacomputing/crossbow @ actions-2e4abf2881](https://github.com/ursacomputing/crossbow/branches/all?query=actions-2e4abf2881)
|Task|Status|
|----|------|
|test-debian-11-go-1.17|[](https://github.com/ursacomputing/crossbow/runs/13088115679)|
|test-debian-11-go-1.20|[](https://github.com/ursacomputing/crossbow/runs/13088114748)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35338: GH-35337: [Go] ASAN tests fail with Go1.20+
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35338:
URL: https://github.com/apache/arrow/pull/35338#issuecomment-1522263667
Revision: 1dc67f118c4ad5fe34543988215972cd635ecd15
Submitted crossbow builds: [ursacomputing/crossbow @ actions-c59f1a2323](https://github.com/ursacomputing/crossbow/branches/all?query=actions-c59f1a2323)
|Task|Status|
|----|------|
|test-debian-11-go-1.17|[](https://github.com/ursacomputing/crossbow/runs/13016983181)|
|test-debian-11-go-1.20|[](https://github.com/ursacomputing/crossbow/runs/13016981308)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35338: GH-35337: [Go] ASAN tests fail with Go1.20+
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35338:
URL: https://github.com/apache/arrow/pull/35338#issuecomment-1522280552
Revision: 11a355a779179ae9f9934a436359f88fe4044c11
Submitted crossbow builds: [ursacomputing/crossbow @ actions-4916b241a1](https://github.com/ursacomputing/crossbow/branches/all?query=actions-4916b241a1)
|Task|Status|
|----|------|
|test-debian-11-go-1.17|[](https://github.com/ursacomputing/crossbow/runs/13017341193)|
|test-debian-11-go-1.20|[](https://github.com/ursacomputing/crossbow/runs/13017340727)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #35338: GH-35337: [Go] ASAN tests fail with Go1.20+
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #35338:
URL: https://github.com/apache/arrow/pull/35338#issuecomment-1522353636
@github-actions crossbow submit "*go-1*"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a diff in pull request #35338: GH-35337: [Go] ASAN tests fail with Go1.20+
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #35338:
URL: https://github.com/apache/arrow/pull/35338#discussion_r1177214319
##########
go/go.mod:
##########
@@ -16,7 +16,7 @@
module github.com/apache/arrow/go/v12
-go 1.18
+go 1.20
Review Comment:
are we OK bumping up the minimum here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35338: GH-35337: [Go] ASAN tests fail with Go1.20+
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35338:
URL: https://github.com/apache/arrow/pull/35338#issuecomment-1522150285
* Closes: #35337
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35338: GH-35337: [Go] ASAN tests fail with Go1.20+
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35338:
URL: https://github.com/apache/arrow/pull/35338#issuecomment-1522314955
Revision: a6043a2573aaa4277b07d5f4e7325edd81f85a34
Submitted crossbow builds: [ursacomputing/crossbow @ actions-bec7155954](https://github.com/ursacomputing/crossbow/branches/all?query=actions-bec7155954)
|Task|Status|
|----|------|
|test-debian-11-go-1.17|[](https://github.com/ursacomputing/crossbow/runs/13017974385)|
|test-debian-11-go-1.20|[](https://github.com/ursacomputing/crossbow/runs/13017973900)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on a diff in pull request #35338: GH-35337: [Go] ASAN tests fail with Go1.20+
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on code in PR #35338:
URL: https://github.com/apache/arrow/pull/35338#discussion_r1178127084
##########
go/arrow/compute/arithmetic.go:
##########
@@ -343,11 +343,11 @@ NaN values return NaN. Integral values return signedness as Int8,
and floating-point values return it with the same type as the input values.`,
ArgNames: []string{"x"},
}
- bitWiseNotDoc = FunctionDoc{
- Summary: "Bit-wise negate the arguments element-wise",
- Description: "Null values return null",
- ArgNames: []string{"x"},
- }
+ // bitWiseNotDoc = FunctionDoc{
+ // Summary: "Bit-wise negate the arguments element-wise",
+ // Description: "Null values return null",
+ // ArgNames: []string{"x"},
+ // }
Review Comment:
good point i missed that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #35338: GH-35337: [Go] ASAN tests fail with Go1.20+
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #35338:
URL: https://github.com/apache/arrow/pull/35338#issuecomment-1522330156
@github-actions crossbow submit "*go-1*"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #35338: GH-35337: [Go] ASAN tests fail with Go1.20+
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #35338:
URL: https://github.com/apache/arrow/pull/35338#discussion_r1178507909
##########
go/internal/hashing/hash_string.go:
##########
@@ -0,0 +1,30 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+//go:build !go1.20
Review Comment:
I see.
Then how about renaming this file to `hash_string_go1.19.go` and `hash_string_go1.20.go` to `hash_string.go`? Because this file is a special case and `hash_string_go1.20.go` is the normal case in future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #35338: GH-35337: [Go] ASAN tests fail with Go1.20+
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #35338:
URL: https://github.com/apache/arrow/pull/35338#discussion_r1177169685
##########
go/arrow/array/numericbuilder.gen.go.tmpl:
##########
@@ -225,23 +225,23 @@ func (b *{{.Name}}Builder) AppendValueFromString(s string) error {
}
b.Append(v)
{{else if (eq .Name "Duration") -}}
- return fmt.Errorf("%w: AppendValueFromString not implemented for Duration", ErrNotImplemented)
+ return fmt.Errorf("%w: AppendValueFromString not implemented for Duration", arrow.ErrNotImplemented)
{{else if or (eq .Name "Int8") (eq .Name "Int16") (eq .Name "Int32") (eq .Name "Int64") -}}
- v, err := strconv.ParseInt(s, 10, {{.Size}})
+ v, err := strconv.ParseInt(s, 10, {{.Size}}*8)
Review Comment:
```suggestion
v, err := strconv.ParseInt(s, 10, {{.Size}} * 8)
```
##########
go/arrow/compute/arithmetic.go:
##########
@@ -343,11 +343,11 @@ NaN values return NaN. Integral values return signedness as Int8,
and floating-point values return it with the same type as the input values.`,
ArgNames: []string{"x"},
}
- bitWiseNotDoc = FunctionDoc{
- Summary: "Bit-wise negate the arguments element-wise",
- Description: "Null values return null",
- ArgNames: []string{"x"},
- }
+ // bitWiseNotDoc = FunctionDoc{
+ // Summary: "Bit-wise negate the arguments element-wise",
+ // Description: "Null values return null",
+ // ArgNames: []string{"x"},
+ // }
Review Comment:
Is this intended?
Should we use it instead of commenting out this?
```diff
diff --git a/go/arrow/compute/arithmetic.go b/go/arrow/compute/arithmetic.go
index 45d8d7738..e89077cf3 100644
--- a/go/arrow/compute/arithmetic.go
+++ b/go/arrow/compute/arithmetic.go
@@ -909,7 +909,7 @@ func RegisterScalarArithmetic(reg FunctionRegistry) {
reg.AddFunction(fn, false)
}
- fn = &arithmeticFunction{*NewScalarFunction("bit_wise_not", Unary(), EmptyFuncDoc), decPromoteNone}
+ fn = &arithmeticFunction{*NewScalarFunction("bit_wise_not", Unary(), BitWiseNotDoc), decPromoteNone}
for _, k := range kernels.GetBitwiseUnaryKernels() {
if err := fn.AddKernel(k); err != nil {
panic(err)
```
##########
go/arrow/array/numericbuilder.gen.go.tmpl:
##########
@@ -225,23 +225,23 @@ func (b *{{.Name}}Builder) AppendValueFromString(s string) error {
}
b.Append(v)
{{else if (eq .Name "Duration") -}}
- return fmt.Errorf("%w: AppendValueFromString not implemented for Duration", ErrNotImplemented)
+ return fmt.Errorf("%w: AppendValueFromString not implemented for Duration", arrow.ErrNotImplemented)
{{else if or (eq .Name "Int8") (eq .Name "Int16") (eq .Name "Int32") (eq .Name "Int64") -}}
- v, err := strconv.ParseInt(s, 10, {{.Size}})
+ v, err := strconv.ParseInt(s, 10, {{.Size}}*8)
if err != nil {
b.AppendNull()
return err
}
b.Append({{.name}}(v))
{{else if or (eq .Name "Uint8") (eq .Name "Uint16") (eq .Name "Uint32") (eq .Name "Uint64") -}}
- v, err := strconv.ParseUint(s, 10, {{.Size}})
+ v, err := strconv.ParseUint(s, 10, {{.Size}}*8)
Review Comment:
```suggestion
v, err := strconv.ParseUint(s, 10, {{.Size}} * 8)
```
##########
go/internal/hashing/hash_string.go:
##########
@@ -0,0 +1,30 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+//go:build !go1.20
Review Comment:
Does this work with go1.21 or later?
(I think that the answer is "no".)
Can we use `//go:build <go1.20` or something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #35338: GH-35337: [Go] ASAN tests fail with Go1.20+
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #35338:
URL: https://github.com/apache/arrow/pull/35338#issuecomment-1522277871
@github-actions crossbow submit "*go-1*"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35338: GH-35337: [Go] ASAN tests fail with Go1.20+
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35338:
URL: https://github.com/apache/arrow/pull/35338#issuecomment-1522392672
Revision: f22c7e3c967775384527a57ceaf1274fdfde5ca6
Submitted crossbow builds: [ursacomputing/crossbow @ actions-5eaf3e2e1a](https://github.com/ursacomputing/crossbow/branches/all?query=actions-5eaf3e2e1a)
|Task|Status|
|----|------|
|test-debian-11-go-1.17|[](https://github.com/ursacomputing/crossbow/runs/13019662949)|
|test-debian-11-go-1.20|[](https://github.com/ursacomputing/crossbow/runs/13019664527)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35338: GH-35337: [Go] ASAN tests fail with Go1.20+
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35338:
URL: https://github.com/apache/arrow/pull/35338#issuecomment-1522263119
Revision: 1dc67f118c4ad5fe34543988215972cd635ecd15
Submitted crossbow builds: [ursacomputing/crossbow @ actions-e4a80302cc](https://github.com/ursacomputing/crossbow/branches/all?query=actions-e4a80302cc)
|Task|Status|
|----|------|
|test-debian-11-go-1.17|[](https://github.com/ursacomputing/crossbow/runs/13016972316)|
|test-debian-11-go-1.20|[](https://github.com/ursacomputing/crossbow/runs/13016971798)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #35338: GH-35337: [Go] ASAN tests fail with Go1.20+
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #35338:
URL: https://github.com/apache/arrow/pull/35338#issuecomment-1522260383
@github-actions crossbow submit *go-1*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #35338: GH-35337: [Go] ASAN tests fail with Go1.20+
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #35338:
URL: https://github.com/apache/arrow/pull/35338#issuecomment-1522266671
@github-actions crossbow submit "*go-1*"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35338: GH-35337: [Go] ASAN tests fail with Go1.20+
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35338:
URL: https://github.com/apache/arrow/pull/35338#issuecomment-1522304612
Revision: 15c825b0282b8d2c6f42801112a9752f73408ab6
Submitted crossbow builds: [ursacomputing/crossbow @ actions-0e042cd03b](https://github.com/ursacomputing/crossbow/branches/all?query=actions-0e042cd03b)
|Task|Status|
|----|------|
|test-debian-11-go-1.17|[](https://github.com/ursacomputing/crossbow/runs/13017777309)|
|test-debian-11-go-1.20|[](https://github.com/ursacomputing/crossbow/runs/13017776846)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35338: GH-35337: [Go] ASAN tests fail with Go1.20+
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35338:
URL: https://github.com/apache/arrow/pull/35338#issuecomment-1522368717
Revision: 5d553c8342d5e33b3c9084be56e3b6ebd4688d82
Submitted crossbow builds: [ursacomputing/crossbow @ actions-49fb306798](https://github.com/ursacomputing/crossbow/branches/all?query=actions-49fb306798)
|Task|Status|
|----|------|
|test-debian-11-go-1.17|[](https://github.com/ursacomputing/crossbow/runs/13019160391)|
|test-debian-11-go-1.20|[](https://github.com/ursacomputing/crossbow/runs/13019159179)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35338: GH-35337: [Go] ASAN tests fail with Go1.20+
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35338:
URL: https://github.com/apache/arrow/pull/35338#issuecomment-1522356677
Revision: e63240d9d28aa30e2a14112123e8aa7c3683c2c2
Submitted crossbow builds: [ursacomputing/crossbow @ actions-510fafe9e3](https://github.com/ursacomputing/crossbow/branches/all?query=actions-510fafe9e3)
|Task|Status|
|----|------|
|test-debian-11-go-1.17|[](https://github.com/ursacomputing/crossbow/runs/13018883070)|
|test-debian-11-go-1.20|[](https://github.com/ursacomputing/crossbow/runs/13018882546)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #35338: GH-35337: [Go] ASAN tests fail with Go1.20+
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #35338:
URL: https://github.com/apache/arrow/pull/35338#issuecomment-1522389838
@github-actions crossbow submit "*go-1*"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on pull request #35338: GH-35337: [Go] ASAN tests fail with Go1.20+
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #35338:
URL: https://github.com/apache/arrow/pull/35338#issuecomment-1522552910
I can´t really review these changes but I agree that they are not a blocker but if we cut a second rc they should be added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #35338: GH-35337: [Go] ASAN tests fail with Go1.20+
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #35338:
URL: https://github.com/apache/arrow/pull/35338
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org