You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/04/01 05:29:22 UTC
[GitHub] [rocketmq] rushsky518 opened a new pull request #1903: Print log
when flush timeout
rushsky518 opened a new pull request #1903: Print log when flush timeout
URL: https://github.com/apache/rocketmq/pull/1903
## What is the purpose of the change
Print log when flush timeout
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] coveralls edited a comment on issue #1903: [ISSUE #1904]
Print log when flush timeout
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1903: [ISSUE #1904] Print log when flush timeout
URL: https://github.com/apache/rocketmq/pull/1903#issuecomment-607046215
[](https://coveralls.io/builds/29765092)
Coverage decreased (-0.009%) to 50.905% when pulling **4871108ec95f0a13ba6204b53982d92c2b6871b7 on rushsky518:timeout_msg** into **0a9822e5f4667654b37bd480865174d1bb2c28fe on apache:develop**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] rushsky518 commented on a change in pull request #1903:
[ISSUE #1904] Print log when flush timeout
Posted by GitBox <gi...@apache.org>.
rushsky518 commented on a change in pull request #1903: [ISSUE #1904] Print log when flush timeout
URL: https://github.com/apache/rocketmq/pull/1903#discussion_r403074273
##########
File path: store/src/main/java/org/apache/rocketmq/store/CommitLog.java
##########
@@ -761,15 +767,20 @@ public long getBeginTimeInLock() {
storeStatsService.getSinglePutMessageTopicTimesTotal(messageExtBatch.getTopic()).addAndGet(result.getMsgNum());
storeStatsService.getSinglePutMessageTopicSizeTotal(messageExtBatch.getTopic()).addAndGet(result.getWroteBytes());
- CompletableFuture<PutMessageStatus> flushOKFuture = submitFlushRequest(result, putMessageResult, messageExtBatch);
- CompletableFuture<PutMessageStatus> replicaOKFuture = submitReplicaRequest(result, putMessageResult, messageExtBatch);
+ CompletableFuture<PutMessageStatus> flushOKFuture = submitFlushRequest(result, messageExtBatch);
+ CompletableFuture<PutMessageStatus> replicaOKFuture = submitReplicaRequest(result, messageExtBatch);
return flushOKFuture.thenCombine(replicaOKFuture, (flushStatus, replicaStatus) -> {
if (flushStatus != PutMessageStatus.PUT_OK) {
- putMessageResult.setPutMessageStatus(PutMessageStatus.FLUSH_DISK_TIMEOUT);
+ putMessageResult.setPutMessageStatus(flushStatus);
+ log.error("do groupcommit, wait for flush failed, topic: {} tags: {} client address: {}",
Review comment:
Indeed so.
I still have a question about [#1894 pr]
````java
req.wakeupCustomer(flushOK ? PutMessageStatus.PUT_OK : PutMessageStatus.FLUSH_DISK_TIMEOUT);
````
flushOK is false means FLUSH_DISK_TIMEOUT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] coveralls edited a comment on issue #1903: [ISSUE #1904]
Print log when flush timeout
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1903: [ISSUE #1904] Print log when flush timeout
URL: https://github.com/apache/rocketmq/pull/1903#issuecomment-607046215
[](https://coveralls.io/builds/29840482)
Coverage decreased (-0.009%) to 50.905% when pulling **80ebef3120d9c66d916a0fbbdf665be7b7d1033e on rushsky518:timeout_msg** into **0a9822e5f4667654b37bd480865174d1bb2c28fe on apache:develop**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] ShannonDing commented on issue #1903: [ISSUE #1904]
Print log when flush timeout
Posted by GitBox <gi...@apache.org>.
ShannonDing commented on issue #1903: [ISSUE #1904] Print log when flush timeout
URL: https://github.com/apache/rocketmq/pull/1903#issuecomment-607142356
It seems to conflict with #1894, could you please check again?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] codecov-io edited a comment on issue #1903: [ISSUE
#1904] Print log when flush timeout
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1903: [ISSUE #1904] Print log when flush timeout
URL: https://github.com/apache/rocketmq/pull/1903#issuecomment-607046052
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/1903?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`develop@c5e5f8d`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/rocketmq/pull/1903?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #1903 +/- ##
==========================================
Coverage ? 45.11%
Complexity ? 4196
==========================================
Files ? 544
Lines ? 35733
Branches ? 4746
==========================================
Hits ? 16120
Misses ? 17571
Partials ? 2042
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/1903?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/1903?src=pr&el=footer). Last update [c5e5f8d...b3c1ba7](https://codecov.io/gh/apache/rocketmq/pull/1903?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] codecov-io edited a comment on issue #1903: [ISSUE
#1904] Print log when flush timeout
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1903: [ISSUE #1904] Print log when flush timeout
URL: https://github.com/apache/rocketmq/pull/1903#issuecomment-607046052
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/1903?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`develop@c5e5f8d`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/rocketmq/pull/1903?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #1903 +/- ##
==========================================
Coverage ? 45.10%
Complexity ? 4198
==========================================
Files ? 544
Lines ? 35732
Branches ? 4746
==========================================
Hits ? 16116
Misses ? 17566
Partials ? 2050
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/1903?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/1903?src=pr&el=footer). Last update [c5e5f8d...80ebef3](https://codecov.io/gh/apache/rocketmq/pull/1903?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] ShannonDing commented on a change in pull request #1903:
[ISSUE #1904] Print log when flush timeout
Posted by GitBox <gi...@apache.org>.
ShannonDing commented on a change in pull request #1903: [ISSUE #1904] Print log when flush timeout
URL: https://github.com/apache/rocketmq/pull/1903#discussion_r402909145
##########
File path: store/src/main/java/org/apache/rocketmq/store/CommitLog.java
##########
@@ -761,15 +767,20 @@ public long getBeginTimeInLock() {
storeStatsService.getSinglePutMessageTopicTimesTotal(messageExtBatch.getTopic()).addAndGet(result.getMsgNum());
storeStatsService.getSinglePutMessageTopicSizeTotal(messageExtBatch.getTopic()).addAndGet(result.getWroteBytes());
- CompletableFuture<PutMessageStatus> flushOKFuture = submitFlushRequest(result, putMessageResult, messageExtBatch);
- CompletableFuture<PutMessageStatus> replicaOKFuture = submitReplicaRequest(result, putMessageResult, messageExtBatch);
+ CompletableFuture<PutMessageStatus> flushOKFuture = submitFlushRequest(result, messageExtBatch);
+ CompletableFuture<PutMessageStatus> replicaOKFuture = submitReplicaRequest(result, messageExtBatch);
return flushOKFuture.thenCombine(replicaOKFuture, (flushStatus, replicaStatus) -> {
if (flushStatus != PutMessageStatus.PUT_OK) {
- putMessageResult.setPutMessageStatus(PutMessageStatus.FLUSH_DISK_TIMEOUT);
+ putMessageResult.setPutMessageStatus(flushStatus);
+ log.error("do groupcommit, wait for flush failed, topic: {} tags: {} client address: {}",
Review comment:
If the disk flashing has failed, and continue to log here, it will increase the system load and increase disk IO.
IMO, as the status will be sent to the client, it is better to remove the error log here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] coveralls edited a comment on issue #1903: [ISSUE #1904]
Print log when flush timeout
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1903: [ISSUE #1904] Print log when flush timeout
URL: https://github.com/apache/rocketmq/pull/1903#issuecomment-607046215
[](https://coveralls.io/builds/29826774)
Coverage decreased (-0.05%) to 50.869% when pulling **b3c1ba7dcbaa4f40f0e26f1834df5f118c65e3f1 on rushsky518:timeout_msg** into **0a9822e5f4667654b37bd480865174d1bb2c28fe on apache:develop**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] codecov-io edited a comment on issue #1903: [ISSUE
#1904] Print log when flush timeout
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1903: [ISSUE #1904] Print log when flush timeout
URL: https://github.com/apache/rocketmq/pull/1903#issuecomment-607046052
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/1903?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`develop@c5e5f8d`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/rocketmq/pull/1903?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #1903 +/- ##
==========================================
Coverage ? 45.06%
Complexity ? 4191
==========================================
Files ? 544
Lines ? 35732
Branches ? 4745
==========================================
Hits ? 16103
Misses ? 17594
Partials ? 2035
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/1903?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/1903?src=pr&el=footer). Last update [c5e5f8d...4871108](https://codecov.io/gh/apache/rocketmq/pull/1903?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] rushsky518 commented on issue #1903: Print log when
flush timeout
Posted by GitBox <gi...@apache.org>.
rushsky518 commented on issue #1903: Print log when flush timeout
URL: https://github.com/apache/rocketmq/pull/1903#issuecomment-607045586
#1904
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] codecov-io commented on issue #1903: Print log when
flush timeout
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1903: Print log when flush timeout
URL: https://github.com/apache/rocketmq/pull/1903#issuecomment-607046052
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/1903?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`develop@c5e5f8d`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/rocketmq/pull/1903?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #1903 +/- ##
==========================================
Coverage ? 47.61%
Complexity ? 3098
==========================================
Files ? 416
Lines ? 25970
Branches ? 3441
==========================================
Hits ? 12366
Misses ? 11982
Partials ? 1622
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/1903?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/1903?src=pr&el=footer). Last update [c5e5f8d...b251e1e](https://codecov.io/gh/apache/rocketmq/pull/1903?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] coveralls commented on issue #1903: Print log when flush
timeout
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1903: Print log when flush timeout
URL: https://github.com/apache/rocketmq/pull/1903#issuecomment-607046215
[](https://coveralls.io/builds/29760285)
Coverage increased (+0.1%) to 50.908% when pulling **b251e1e2512641a32898366d95dd26c8eb9a1e1c on rushsky518:timeout_msg** into **a991ea5a7959463ab751ebb17e3f25403924de29 on apache:develop**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services