You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by Fred Moyer <fr...@redhotpenguin.com> on 2009/04/21 07:41:56 UTC

[patch] Apache::Test #41239: t/TEST -ping does not return a valid return code to the calling shell

http://rt.cpan.org/Public/Bug/Display.html?id=41239

This patch as demonstrated in the RT ticket resolves the issue.
Thoughts?  Demonstrating documented behavior here on my test setup
(returning 1 return code to the shell).

Index: lib/Apache/TestRun.pm
===================================================================
--- lib/Apache/TestRun.pm       (revision 766391)
+++ lib/Apache/TestRun.pm       (working copy)
@@ -1173,6 +1173,7 @@
     }
     else {
         warning "no server is running on $name";
+        exit_perl(0);
     }

     return $exit; #means call exit() if true

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: [patch] Apache::Test #41239: t/TEST -ping does not return a valid return code to the calling shell

Posted by Adam Prime <ad...@utoronto.ca>.
Fred Moyer wrote:
> http://rt.cpan.org/Public/Bug/Display.html?id=41239
> 
> This patch as demonstrated in the RT ticket resolves the issue.
> Thoughts?  Demonstrating documented behavior here on my test setup
> (returning 1 return code to the shell).
> 

This seems reasonable to me.

Adam

> Index: lib/Apache/TestRun.pm
> ===================================================================
> --- lib/Apache/TestRun.pm       (revision 766391)
> +++ lib/Apache/TestRun.pm       (working copy)
> @@ -1173,6 +1173,7 @@
>      }
>      else {
>          warning "no server is running on $name";
> +        exit_perl(0);
>      }
> 
>      return $exit; #means call exit() if true
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org