You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Abhishek Kadam <ab...@gmail.com> on 2018/06/08 14:05:10 UTC

Review Request 67508: ATLAS-2747: UI : Tag attributes of type array are displayed with an extra ">" character.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67508/
-----------------------------------------------------------

Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.


Bugs: ATLAS-2747
    https://issues.apache.org/jira/browse/ATLAS-2747


Repository: atlas


Description
-------

This patch includes fix to render objects of non-primitive data-type.

#On edit popup only primitive datatypes objects are shown to edit.


Diffs
-----

  dashboardv2/public/js/utils/Overrides.js a96fc2c 
  dashboardv2/public/js/views/tag/AddTagModalView.js e442f57 
  dashboardv2/public/js/views/tag/TagDetailTableLayoutView.js 35e0f87 


Diff: https://reviews.apache.org/r/67508/diff/1/


Testing
-------

Performed sanity test on UI


Thanks,

Abhishek Kadam


Re: Review Request 67508: ATLAS-2747: UI : Tag attributes of type array are displayed with an extra ">" character.

Posted by Nixon Rodrigues <ni...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67508/#review204489
-----------------------------------------------------------


Ship it!




Ship It!

- Nixon Rodrigues


On June 8, 2018, 2:05 p.m., Abhishek Kadam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67508/
> -----------------------------------------------------------
> 
> (Updated June 8, 2018, 2:05 p.m.)
> 
> 
> Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-2747
>     https://issues.apache.org/jira/browse/ATLAS-2747
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> This patch includes fix to render objects of non-primitive data-type.
> 
> #On edit popup only primitive datatypes objects are shown to edit.
> 
> 
> Diffs
> -----
> 
>   dashboardv2/public/js/utils/Overrides.js a96fc2c 
>   dashboardv2/public/js/views/tag/AddTagModalView.js e442f57 
>   dashboardv2/public/js/views/tag/TagDetailTableLayoutView.js 35e0f87 
> 
> 
> Diff: https://reviews.apache.org/r/67508/diff/1/
> 
> 
> Testing
> -------
> 
> Performed sanity test on UI
> 
> 
> Thanks,
> 
> Abhishek Kadam
> 
>