You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by Brad Nicholes <BN...@novell.com> on 2005/11/11 19:20:10 UTC

Proper declaration for apr_wait_for_io_or_timeout() (was: Re: NWGNUmakefile update for APR1.2?)

  Reposting to the APR list with a new subject line.  Does this need to
be taken care of in APR 1.2.x before httpd 2.2 ships?

Brad

>>> On 11/10/2005 at 4:00:20 pm, in message
<43...@bocnet.com.au>,
normw@bocnet.com.au wrote:
> Greetings All,
> (Blush)
> Seems the missing symbol is lost from aprlib.imp; a check of APR 1.2

> shows the function is declared in apr_support.h as:
> 
>> apr_status_t apr_wait_for_io_or_timeout(apr_file_t *f, apr_socket_t
*s,
>>                                         int for_read);
> 
> Shouldn't that be APR_DECLARE(apr_status_t) for public symbols?
> Norm
> 
> NormW wrote:
>> Greetings All,
>> Just trying a build of NetWare 2.1 head and from results it seems
like 
>> the NWGNUmakefile in the root of APR 1.2 needs an added 'include':
>> 
>> $(APR)/support/unix/ \
>> 
>> if NetWare is to use waitio.c and apr_wait_for_io_or_timeout().
>> Cheers,
>> Norm

Re: Proper declaration for apr_wait_for_io_or_timeout() (was: Re: NWGNUmakefile update for APR1.2?)

Posted by Brian Pane <br...@apache.org>.
On Nov 11, 2005, at 6:21 PM, Jeff Trawick wrote:

> On 11/11/05, Brad Nicholes <BN...@novell.com> wrote:
>>
>>>>> On 11/11/2005 at 1:40:32 pm, in message
>> <cc...@mail.gmail.com>, Jeff
>> Trawick
>> <tr...@gmail.com> wrote:
>>> On 11/11/05, Brad Nicholes <BN...@novell.com> wrote:
>>>>   Reposting to the APR list with a new subject line.  Does this  
>>>> need
>> to
>>>> be taken care of in APR 1.2.x before httpd 2.2 ships?
>>>
>>> apr_wait_for_io_or_timeout() is private APR function (not API).  Is
>>> the caller outside of APR?
>>
>> Yes, HTTPD.  trunk/server/core_filters.c
>
> Simply shocking ;)  That code needs to be fixed to call a real API :(

I just double-checked the declaration, and apr_wait_for_io_or_timeout()
currently is implemented as part of the public API.  I don't have any  
strong
objection to making it private, though (e.g., by wrapping the  
declaration in
an "#ifdef APR_PRIVATE" or moving apr_support.h to apr/include/arch/ 
unix).

Brian

Re: Proper declaration for apr_wait_for_io_or_timeout() (was: Re: NWGNUmakefile update for APR1.2?)

Posted by Jeff Trawick <tr...@gmail.com>.
On 11/11/05, Brad Nicholes <BN...@novell.com> wrote:
>
> >>> On 11/11/2005 at 1:40:32 pm, in message
> <cc...@mail.gmail.com>, Jeff
> Trawick
> <tr...@gmail.com> wrote:
> > On 11/11/05, Brad Nicholes <BN...@novell.com> wrote:
> >>   Reposting to the APR list with a new subject line.  Does this need
> to
> >> be taken care of in APR 1.2.x before httpd 2.2 ships?
> >
> > apr_wait_for_io_or_timeout() is private APR function (not API).  Is
> > the caller outside of APR?
>
> Yes, HTTPD.  trunk/server/core_filters.c

Simply shocking ;)  That code needs to be fixed to call a real API :(

Re: Proper declaration for apr_wait_for_io_or_timeout() (was: Re: NWGNUmakefile update for APR1.2?)

Posted by Brad Nicholes <BN...@novell.com>.
>>> On 11/11/2005 at 1:40:32 pm, in message
<cc...@mail.gmail.com>, Jeff
Trawick
<tr...@gmail.com> wrote:
> On 11/11/05, Brad Nicholes <BN...@novell.com> wrote:
>>   Reposting to the APR list with a new subject line.  Does this need
to
>> be taken care of in APR 1.2.x before httpd 2.2 ships?
> 
> apr_wait_for_io_or_timeout() is private APR function (not API).  Is
> the caller outside of APR?

Yes, HTTPD.  trunk/server/core_filters.c

Brad

Re: Proper declaration for apr_wait_for_io_or_timeout() (was: Re: NWGNUmakefile update for APR1.2?)

Posted by Jeff Trawick <tr...@gmail.com>.
On 11/11/05, Brad Nicholes <BN...@novell.com> wrote:
>   Reposting to the APR list with a new subject line.  Does this need to
> be taken care of in APR 1.2.x before httpd 2.2 ships?

apr_wait_for_io_or_timeout() is private APR function (not API).  Is
the caller outside of APR?