You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by 1ambda <gi...@git.apache.org> on 2017/03/05 03:17:29 UTC

[GitHub] zeppelin pull request #2071: [ZEPPELIN-2166] HeliumBundleFactoty can't trans...

GitHub user 1ambda reopened a pull request:

    https://github.com/apache/zeppelin/pull/2071

    [ZEPPELIN-2166] HeliumBundleFactoty can't transfile imported es6+

    ### What is this PR for?
    
    Currently, we don't use any preset. This cause error messages like
    when a helium package imports another packages which include es6+ syntax.
    
    ```
    SyntaxError: Unexpected token import
        at helium.service.js:36
        at angular.js:10973
        at processQueue (angular.js:15552)
        at angular.js:15568
        at Scope.$eval (angular.js:16820)
        at Scope.$digest (angular.js:16636)
        at Scope.$apply (angular.js:16928)
        at done (angular.js:11266)
        at completeRequest (angular.js:11464)
        at XMLHttpRequest.requestLoaded (angular.js:11405)
    ```
    
    - https://github.com/1ambda/zeppelin-advanced-transformation/blob/master/examples/example-highcharts-columnrange/index.js#L3
    - https://github.com/1ambda/zeppelin-advanced-transformation/blob/master/index.js#L11
    
    ### What type of PR is it?
    [Improvement]
    
    ### Todos
    * [x] - Install required NPM packages
    * [x] - fix babel configuration
    
    ### What is the Jira issue?
    
    [ZEPPELIN-2166](https://issues.apache.org/jira/browse/ZEPPELIN-2166)
    
    ### How should this be tested?
    
    - Should be able to bundle existing helium vis
    - Should be able to bundle https://github.com/1ambda/zeppelin-advanced-transformation/tree/master/examples/example-highcharts-columnrange
    
    ### Screenshots (if appropriate)
    
    NONE
    
    ### Questions:
    * Does the licenses files need update? - NONE
    * Is there breaking changes for older versions? - NONE
    * Does this needs documentation? - NONE


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2166/fix-webpack-config-for-es6

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2071.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2071
    
----
commit 40f6b51dfc1695fb8ef9c63e56af37d9f1e14994
Author: 1ambda <1a...@gmail.com>
Date:   2017-02-27T02:35:38Z

    fix: Update babel configuration

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---