You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by gubaojian <gi...@git.apache.org> on 2018/03/26 07:16:58 UTC
[GitHub] incubator-weex pull request #1086: [WEEX-224][android] WXDomObject Destory M...
GitHub user gubaojian opened a pull request:
https://github.com/apache/incubator-weex/pull/1086
[WEEX-224][android] WXDomObject Destory Method Should Be Called avoid Memory Leak
[WEEX-224][android] WXDomObject Destory Method Should Be Called avoid Memory Leak
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gubaojian/incubator-weex release-0.18-dom-destory
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/1086.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1086
----
commit 4d25fa3214d0a5a870fd1b1c024d2d48e10c794b
Author: jianbai.gbj <ji...@...>
Date: 2018-02-24T09:16:56Z
[WEEX-224][android] WXDomObject Destory Method Should Be Called avoid Memory Leak
commit 721174dec713441f4e56ad5d598739e14cac81eb
Author: jianbai.gbj <ji...@...>
Date: 2018-02-26T06:31:33Z
[WEEX-224][android] WXDomObject Destory Method Should Be Called avoid Memory Leak
----
---
[GitHub] incubator-weex pull request #1086: [WEEX-224][android] WXDomObject Destory M...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/1086
---
[GitHub] incubator-weex issue #1086: [WEEX-224][android] WXDomObject Destory Method S...
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/1086
<!--
0 failure:
2 warning: No Changelog chan..., Potential BREAK C...
1 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Warnings</th>
</tr>
</thead>
<tbody><tr>
<td>:warning:</td>
<td>No Changelog changes!</td>
</tr>
<tr>
<td>:warning:</td>
<td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/dom/WXTextDomObject.java without metion it in commit message. You'd better add '@notdanger' in your commit log. </td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>danger test finished.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
---