[jira] [Commented] (FLINK-7273) Gelly tests with empty graphs

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102190#comment-16102190 ] 

ASF GitHub Bot commented on FLINK-7273:
---------------------------------------

GitHub user greghogan opened a pull request:

    https://github.com/apache/flink/pull/4405

    [FLINK-7273] [gelly] Gelly tests with empty graphs

    ## What is the purpose of the change
    
    This was prompted by user feedback comparing Gelly's `PageRank` which noticed that zero-degree vertices (not present in the edge set) were not included in the computation. There existed an `EmptyGraph` generated which was sometimes used. This PR adds missing tests using empty edge and vertex sets for each algorithm.
    
    ## Brief change log
    
    There exist some tests with empty graphs but the `EmptyGraph` in `AsmTestBase` contained vertices but no edges. Add a new `EmptyGraph` without vertices and test both empty graphs for each algorithm.
    
    EmptyGraph now generates the proper TypeInformation (for Edge<> not Tuple3) which had prevented adding edges due to a union incompatibility.
    
    GraphGeneratorUtils#vertexSet now uses a hash-combine for distinct.
    
    `PageRank` optionally includes zero-degree vertices in the results (at a performance cost).
    
    ## Verifying this change
    
    This change added tests and can be verified as follows: running new unit tests
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes / **no**)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (**yes** / no)
      - If yes, how is the feature documented? (not applicable / **docs** / JavaDocs / not documented)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/greghogan/flink 7273_gelly_tests_with_empty_graphs

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4405.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4405
    
----
commit 060db79d29782ba9078b1461c74019c4c68ae224
Author: Greg Hogan <co...@greghogan.com>
Date:   2017-07-26T10:23:52Z

    [FLINK-7273] [gelly] Gelly tests with empty graphs
    
    There exist some tests with empty graphs but the `EmptyGraph` in
    `AsmTestBase` contained vertices but no edges. Add a new `EmptyGraph`
    without vertices and test both empty graphs for each algorithm.
    
    EmptyGraph now generates the proper TypeInformation (for Edge<> not
    Tuple3) which had prevented adding edges due to a union incompatibility.
    
    GraphGeneratorUtils#vertexSet now uses a hash-combine for distinct.
    
    `PageRank` optionally includes zero-degree vertices in the results
    (at a performance cost).

----


> Gelly tests with empty graphs
> -----------------------------
>
>                 Key: FLINK-7273
>                 URL: https://issues.apache.org/jira/browse/FLINK-7273
>             Project: Flink
>          Issue Type: Bug
>          Components: Gelly
>    Affects Versions: 1.4.0
>            Reporter: Greg Hogan
>            Assignee: Greg Hogan
>            Priority: Minor
>             Fix For: 1.4.0
>
>
> There exist some tests with empty graphs but the `EmptyGraph` in `AsmTestBase` contained vertices but no edges. Add a new `EmptyGraph` without vertices and test both empty graphs for each algorithm.
> `PageRank` should (optionally?) include zero-degree vertices in the results.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)