You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by se...@apache.org on 2017/02/21 16:28:58 UTC
svn commit: r1783908 -
/jmeter/trunk/test/src/org/apache/jorphan/reflect/TestClassFinder.java
Author: sebb
Date: Tue Feb 21 16:28:58 2017
New Revision: 1783908
URL: http://svn.apache.org/viewvc?rev=1783908&view=rev
Log:
Fix file search so it returns a jar file and not some other file such as aareadme.txt
Modified:
jmeter/trunk/test/src/org/apache/jorphan/reflect/TestClassFinder.java
Modified: jmeter/trunk/test/src/org/apache/jorphan/reflect/TestClassFinder.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/test/src/org/apache/jorphan/reflect/TestClassFinder.java?rev=1783908&r1=1783907&r2=1783908&view=diff
==============================================================================
--- jmeter/trunk/test/src/org/apache/jorphan/reflect/TestClassFinder.java (original)
+++ jmeter/trunk/test/src/org/apache/jorphan/reflect/TestClassFinder.java Tue Feb 21 16:28:58 2017
@@ -102,7 +102,7 @@ public class TestClassFinder {
@Test
public void testFindAllClassesInJar() throws Exception {
- Path jarPath = Files.find(Paths.get(libDirs[0]), 1, (p, a) -> a.isRegularFile()).findFirst()
+ Path jarPath = Files.find(Paths.get(libDirs[0]), 1, (p, a) -> String.valueOf(p).endsWith(".jar")).findFirst()
.orElseThrow(() -> new FileNotFoundException("no jars found")).toRealPath();
List<String> annotatedClasses = ClassFinder.findClasses(new String[] { jarPath.toString() },
c -> true);
Re: svn commit: r1783908 - /jmeter/trunk/test/src/org/apache/jorphan/reflect/TestClassFinder.java
Posted by sebb <se...@gmail.com>.
On 21 February 2017 at 16:48, Felix Schumacher
<fe...@internetallee.de> wrote:
>
>
> Am 21. Februar 2017 17:28:58 MEZ schrieb sebb@apache.org:
>>Author: sebb
>>Date: Tue Feb 21 16:28:58 2017
>>New Revision: 1783908
>>
>>URL: http://svn.apache.org/viewvc?rev=1783908&view=rev
>>Log:
>>Fix file search so it returns a jar file and not some other file such
>>as aareadme.txt
>
> Thanks. This was on my to do list, but I was happy, that it did work for me at that moment.
>
> Did this fail on you?
Yes, it picked up .DS_Store, and then when I deleted that, it still
did not work because of the readme.
> Felix
>
>>
>>Modified:
>> jmeter/trunk/test/src/org/apache/jorphan/reflect/TestClassFinder.java
>>
>>Modified:
>>jmeter/trunk/test/src/org/apache/jorphan/reflect/TestClassFinder.java
>>URL:
>>http://svn.apache.org/viewvc/jmeter/trunk/test/src/org/apache/jorphan/reflect/TestClassFinder.java?rev=1783908&r1=1783907&r2=1783908&view=diff
>>==============================================================================
>>---
>>jmeter/trunk/test/src/org/apache/jorphan/reflect/TestClassFinder.java
>>(original)
>>+++
>>jmeter/trunk/test/src/org/apache/jorphan/reflect/TestClassFinder.java
>>Tue Feb 21 16:28:58 2017
>>@@ -102,7 +102,7 @@ public class TestClassFinder {
>>
>> @Test
>> public void testFindAllClassesInJar() throws Exception {
>>- Path jarPath = Files.find(Paths.get(libDirs[0]), 1, (p, a) ->
>>a.isRegularFile()).findFirst()
>>+ Path jarPath = Files.find(Paths.get(libDirs[0]), 1, (p, a) ->
>>String.valueOf(p).endsWith(".jar")).findFirst()
>>.orElseThrow(() -> new FileNotFoundException("no jars
>>found")).toRealPath();
>>List<String> annotatedClasses = ClassFinder.findClasses(new String[] {
>>jarPath.toString() },
>> c -> true);
Re: svn commit: r1783908 - /jmeter/trunk/test/src/org/apache/jorphan/reflect/TestClassFinder.java
Posted by Felix Schumacher <fe...@internetallee.de>.
Am 21. Februar 2017 17:28:58 MEZ schrieb sebb@apache.org:
>Author: sebb
>Date: Tue Feb 21 16:28:58 2017
>New Revision: 1783908
>
>URL: http://svn.apache.org/viewvc?rev=1783908&view=rev
>Log:
>Fix file search so it returns a jar file and not some other file such
>as aareadme.txt
Thanks. This was on my to do list, but I was happy, that it did work for me at that moment.
Did this fail on you?
Felix
>
>Modified:
> jmeter/trunk/test/src/org/apache/jorphan/reflect/TestClassFinder.java
>
>Modified:
>jmeter/trunk/test/src/org/apache/jorphan/reflect/TestClassFinder.java
>URL:
>http://svn.apache.org/viewvc/jmeter/trunk/test/src/org/apache/jorphan/reflect/TestClassFinder.java?rev=1783908&r1=1783907&r2=1783908&view=diff
>==============================================================================
>---
>jmeter/trunk/test/src/org/apache/jorphan/reflect/TestClassFinder.java
>(original)
>+++
>jmeter/trunk/test/src/org/apache/jorphan/reflect/TestClassFinder.java
>Tue Feb 21 16:28:58 2017
>@@ -102,7 +102,7 @@ public class TestClassFinder {
>
> @Test
> public void testFindAllClassesInJar() throws Exception {
>- Path jarPath = Files.find(Paths.get(libDirs[0]), 1, (p, a) ->
>a.isRegularFile()).findFirst()
>+ Path jarPath = Files.find(Paths.get(libDirs[0]), 1, (p, a) ->
>String.valueOf(p).endsWith(".jar")).findFirst()
>.orElseThrow(() -> new FileNotFoundException("no jars
>found")).toRealPath();
>List<String> annotatedClasses = ClassFinder.findClasses(new String[] {
>jarPath.toString() },
> c -> true);