[jira] [Commented] (TRAFODION-3138) Remove obsolete code from UPDATE STATISTICS

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TRAFODION-3138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540626#comment-16540626 ] 

ASF GitHub Bot commented on TRAFODION-3138:
-------------------------------------------

GitHub user DaveBirdsall opened a pull request:

    https://github.com/apache/trafodion/pull/1639

    [TRAFODION-3138] Part 1 of removing static SQL code from ustats + one bug fix

    This pull request contains two changes:
    
    1. It removes obsolete static SQL code from two ustat modules (hs_read.cpp and hs_update.cpp). It also removes obsolete metadata version checking code. Thanks to @anoopsharma00 for these changes.
    
    2. It fixes a bug in incremental UPDATE STATISTICS. If one has a table name containing a dot (.), incremental UPDATE STATISTICS fails. For example:
    
    ```
    >>update statistics for table "A.B" on existing columns incremental where a > 128;
    
    *** ERROR[15005] Unmatched quote in input (unterminated string): 
    select count(*) from B" where  a > 128;
    
    --- SQL operation failed with errors.
    >>
    ```
    
    This bug has been fixed (hs_globals.cpp). Thanks to @anoopsharma00 also for this change.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DaveBirdsall/trafodion Trafodion3138

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafodion/pull/1639.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1639
    
----
commit 2358b6f6b5e894ccc626fa505eea04c572dacabd
Author: Dave Birdsall <db...@...>
Date:   2018-07-11T20:39:34Z

    [TRAFODION-3138] Part 1 of removing static SQL code from ustats + one bug fix

----


> Remove obsolete code from UPDATE STATISTICS
> -------------------------------------------
>
>                 Key: TRAFODION-3138
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-3138
>             Project: Apache Trafodion
>          Issue Type: Improvement
>            Reporter: David Wayne Birdsall
>            Priority: Major
>
> UPDATE STATISTICS contains code from the predecessor product that uses static SQL for certain operations. Trafodion does not support static SQL, so this code can be removed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)