You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by GitBox <gi...@apache.org> on 2020/03/25 09:28:47 UTC
[GitHub] [felix-dev] bosschaert commented on a change in pull request #10:
[converter] handle default methods - FELIX-6239
bosschaert commented on a change in pull request #10: [converter] handle default methods - FELIX-6239
URL: https://github.com/apache/felix-dev/pull/10#discussion_r397712849
##########
File path: converter/converter/src/main/java/org/osgi/util/converter/ConvertingImpl.java
##########
@@ -810,6 +813,32 @@ public Object invoke(Object proxy, Method method, Object[] args)
if (cls.isAnnotation()) {
val = method.getDefaultValue();
}
+ else if (method.isDefault())
+ {
+ double javaVersion = Double.parseDouble(
+ System.getProperty("java.class.version"));
+ double java8 = 52.0;
+ if (javaVersion > java8)
Review comment:
So invoking default methods is different for Java 8 and Java 9+?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services