You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/02 15:21:59 UTC

[GitHub] [spark] gengliangwang opened a new pull request #31439: [SPARK-33591][SQL][FOLLOWUP] Add legacy config for recognizing null partition spec values

gengliangwang opened a new pull request #31439:
URL: https://github.com/apache/spark/pull/31439


   ### What changes were proposed in this pull request?
       This PR is to backport https://github.com/apache/spark/pull/31421 and https://github.com/apache/spark/pull/31421 to branch 3.1
       It is a follow up for https://github.com/apache/spark/pull/30538.
       It adds a legacy conf `spark.sql.legacy.parseNullPartitionSpecAsStringLiteral` in case users wants the legacy behavior.
       It also adds document for the behavior change.
       
   ### Why are the changes needed?
       
       In case users want the legacy behavior, they can set `spark.sql.legacy.parseNullPartitionSpecAsStringLiteral` as true.
       
   ### Does this PR introduce _any_ user-facing change?
       
       Yes, adding a legacy configuration to restore the old behavior.
       
   ### How was this patch tested?
       
       Unit test.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31439: [SPARK-33591][3.1][SQL][FOLLOWUP] Add legacy config for recognizing null partition spec values

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31439:
URL: https://github.com/apache/spark/pull/31439#issuecomment-771938940


   **[Test build #134787 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134787/testReport)** for PR 31439 at commit [`e5229d7`](https://github.com/apache/spark/commit/e5229d75b4c683d5a21db5b32c80643f44da6f7a).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #31439: [SPARK-33591][3.1][SQL][FOLLOWUP] Add legacy config for recognizing null partition spec values

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31439:
URL: https://github.com/apache/spark/pull/31439#issuecomment-771747138


   **[Test build #134787 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134787/testReport)** for PR 31439 at commit [`e5229d7`](https://github.com/apache/spark/commit/e5229d75b4c683d5a21db5b32c80643f44da6f7a).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31439: [SPARK-33591][SQL][FOLLOWUP] Add legacy config for recognizing null partition spec values

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31439:
URL: https://github.com/apache/spark/pull/31439#issuecomment-771747138


   **[Test build #134787 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134787/testReport)** for PR 31439 at commit [`e5229d7`](https://github.com/apache/spark/commit/e5229d75b4c683d5a21db5b32c80643f44da6f7a).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon closed pull request #31439: [SPARK-33591][3.1][SQL][FOLLOWUP] Add legacy config for recognizing null partition spec values

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #31439:
URL: https://github.com/apache/spark/pull/31439


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #31439: [SPARK-33591][3.1][SQL][FOLLOWUP] Add legacy config for recognizing null partition spec values

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31439:
URL: https://github.com/apache/spark/pull/31439#issuecomment-771840436


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39374/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #31439: [SPARK-33591][3.1][SQL][FOLLOWUP] Add legacy config for recognizing null partition spec values

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31439:
URL: https://github.com/apache/spark/pull/31439#issuecomment-771940044


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134787/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31439: [SPARK-33591][SQL][FOLLOWUP] Add legacy config for recognizing null partition spec values

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31439:
URL: https://github.com/apache/spark/pull/31439#issuecomment-771747138






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #31439: [SPARK-33591][3.1][SQL][FOLLOWUP] Add legacy config for recognizing null partition spec values

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31439:
URL: https://github.com/apache/spark/pull/31439#issuecomment-772111884


   Merged to branch-3.1.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #31439: [SPARK-33591][3.1][SQL][FOLLOWUP] Add legacy config for recognizing null partition spec values

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31439:
URL: https://github.com/apache/spark/pull/31439#issuecomment-771840436






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #31439: [SPARK-33591][3.1][SQL][FOLLOWUP] Add legacy config for recognizing null partition spec values

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31439:
URL: https://github.com/apache/spark/pull/31439#issuecomment-772111884


   Merged to branch-3.1.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #31439: [SPARK-33591][3.1][SQL][FOLLOWUP] Add legacy config for recognizing null partition spec values

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31439:
URL: https://github.com/apache/spark/pull/31439#issuecomment-771747138


   **[Test build #134787 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134787/testReport)** for PR 31439 at commit [`e5229d7`](https://github.com/apache/spark/commit/e5229d75b4c683d5a21db5b32c80643f44da6f7a).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #31439: [SPARK-33591][3.1][SQL][FOLLOWUP] Add legacy config for recognizing null partition spec values

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31439:
URL: https://github.com/apache/spark/pull/31439#issuecomment-771840436


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39374/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #31439: [SPARK-33591][3.1][SQL][FOLLOWUP] Add legacy config for recognizing null partition spec values

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31439:
URL: https://github.com/apache/spark/pull/31439#issuecomment-771840436


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39374/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon closed pull request #31439: [SPARK-33591][3.1][SQL][FOLLOWUP] Add legacy config for recognizing null partition spec values

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #31439:
URL: https://github.com/apache/spark/pull/31439


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org