You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Soumabrata Chakraborty (JIRA)" <ji...@apache.org> on 2017/05/10 18:10:04 UTC

[jira] [Issue Comment Deleted] (YARN-6475) Fix some long function checkstyle issues

     [ https://issues.apache.org/jira/browse/YARN-6475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Soumabrata Chakraborty updated YARN-6475:
-----------------------------------------
    Comment: was deleted

(was: Hi [~templedf],  [~miklos.szegedi@cloudera.com]

With reference to the auto-generated comments from Hadoop QA above:
1. There are no new or modified tests since the patch does not change current behavior of the code in any way -- it just refactors code and makes it more readable.  In fact, we rely on the existing tests passing to ensure that the refactoring has not broken any functionality.
2. The extant findbugs warnings was not the focus of my patch.  I can give them a shot if you feel they should be handled together with this JIRA.

Please advise)

> Fix some long function checkstyle issues
> ----------------------------------------
>
>                 Key: YARN-6475
>                 URL: https://issues.apache.org/jira/browse/YARN-6475
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Miklos Szegedi
>            Assignee: Soumabrata Chakraborty
>            Priority: Trivial
>              Labels: newbie
>             Fix For: 3.0.0-alpha3
>
>         Attachments: YARN-6475.001.patch
>
>
> I am talking about these two:
> {code}
> ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/LinuxContainerExecutor.java:441:  @Override:3: Method length is 176 lines (max allowed is 150). [MethodLength]
> ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/launcher/ContainerLaunch.java:159:  @Override:3: Method length is 158 lines (max allowed is 150). [MethodLength]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org