[jira] [Commented] (CB-13237) VisualStudio 2017

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-13237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356066#comment-16356066 ] 

ASF subversion and git services commented on CB-13237:
------------------------------------------------------

Commit 656ef073f417d59e32a123aa1fc84d3149378b52 in cordova-windows's branch refs/heads/master from Jan Piotrowski
[ https://gitbox.apache.org/repos/asf?p=cordova-windows.git;h=656ef07 ]

CB-13829 Fix tests that were broken since CB-13237 (#246)

* CB-13829 Introduce variable `silent` to control output of commands

* fix first failing test for new default `appx`

* document/structure current state of tests (although some are still failing)

* extrat file and subdir+file expect code into function

* add build target override `8.1` (8.1-win + 8.1-phone)

* add test for new override

* remove duplicated getBuildTargets (and update its internal usage)

* more tests fixed

* silent tests with less output again

* default value for buildConfig that old nodes also understand

* fix

* default value that old nodes also understand

* remove duplicated test and re-number tests

* debug 6a problem with vs17 that is not reproducible locally

* move 6a down so more tests run

* Improve readability of logging

* fix


> VisualStudio 2017
> -----------------
>
>                 Key: CB-13237
>                 URL: https://issues.apache.org/jira/browse/CB-13237
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-windows
>            Reporter: Jesse MacFadyen
>            Assignee: Jesse MacFadyen
>            Priority: Major
>
> Users who only have VS-2017 and the new tools do not have the expected registry items available to 'cordova build' so it fails.
> Failure happens here:
> https://github.com/apache/cordova-windows/blob/a869223824f6ee1a6fc515d4b4aaafc2d8cfba93/template/cordova/lib/build.js#L554
> And the message I saw was 'MSBuild v4.0 is not supported, aborting.'



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org