You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/21 19:54:13 UTC
[GitHub] [incubator-superset] mistercrunch opened a new pull request #10381: style: SIP-34 control-label
mistercrunch opened a new pull request #10381:
URL: https://github.com/apache/incubator-superset/pull/10381
<img width="1002" alt="Screen Shot 2020-07-21 at 12 53 30 PM" src="https://user-images.githubusercontent.com/487433/88100292-36c6a900-cb51-11ea-8a2f-5bf932ca89e6.png">
<img width="1014" alt="Screen Shot 2020-07-21 at 12 53 19 PM" src="https://user-images.githubusercontent.com/487433/88100304-39c19980-cb51-11ea-834f-b39fcb120592.png">
<img width="352" alt="Screen Shot 2020-07-21 at 12 52 38 PM" src="https://user-images.githubusercontent.com/487433/88100306-3a5a3000-cb51-11ea-8fb1-26d85b5171ad.png">
<img width="585" alt="Screen Shot 2020-07-21 at 12 52 10 PM" src="https://user-images.githubusercontent.com/487433/88100307-3a5a3000-cb51-11ea-9a03-9eafc10f8696.png">
<img width="1001" alt="Screen Shot 2020-07-21 at 12 51 37 PM" src="https://user-images.githubusercontent.com/487433/88100308-3af2c680-cb51-11ea-984b-55502000fae4.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #10381: style: SIP-34 control-label
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #10381:
URL: https://github.com/apache/incubator-superset/pull/10381#discussion_r458351029
##########
File path: superset-frontend/stylesheets/less/cosmo/variables.less
##########
@@ -220,7 +220,7 @@
);
// ** `.form-group` margin
-@form-group-margin-bottom: 10px;
+@form-group-margin-bottom: 16px;
Review comment:
moving towards the `8px` system
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch merged pull request #10381: style: SIP-34 control-label
Posted by GitBox <gi...@apache.org>.
mistercrunch merged pull request #10381:
URL: https://github.com/apache/incubator-superset/pull/10381
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #10381: style: SIP-34 control-label
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #10381:
URL: https://github.com/apache/incubator-superset/pull/10381#discussion_r458434814
##########
File path: superset-frontend/stylesheets/less/cosmo/variables.less
##########
@@ -220,7 +220,7 @@
);
// ** `.form-group` margin
-@form-group-margin-bottom: 10px;
+@form-group-margin-bottom: 16px;
Review comment:
I might sweep this (and others) up with a @grid-unit variable... no need to worry for this PR though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on pull request #10381: style: SIP-34 control-label
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #10381:
URL: https://github.com/apache/incubator-superset/pull/10381#issuecomment-679292207
Impacts #8976
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org