You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2019/05/09 17:40:37 UTC

[GitHub] [accumulo] keith-turner commented on a change in pull request #1155: fix #405 - Utilize newTableConfig in ITs

keith-turner commented on a change in pull request #1155: fix #405 - Utilize newTableConfig in ITs
URL: https://github.com/apache/accumulo/pull/1155#discussion_r282590372
 
 

 ##########
 File path: test/src/main/java/org/apache/accumulo/test/replication/MultiInstanceReplicationIT.java
 ##########
 @@ -534,24 +534,18 @@ public void dataWasReplicatedToThePeerWithoutDrain() throws Exception {
           .setProperty(Property.REPLICATION_PEER_PASSWORD.getKey() + peerClusterName, peerPassword);
 
       String masterTable = "master", peerTable = "peer";
-
-      clientMaster.tableOperations().create(masterTable);
-      String masterTableId = clientMaster.tableOperations().tableIdMap().get(masterTable);
-      assertNotNull(masterTableId);
-
-      clientPeer.tableOperations().create(peerTable);
+      clientPeer.tableOperations().create(peerTable, new NewTableConfiguration());
       String peerTableId = clientPeer.tableOperations().tableIdMap().get(peerTable);
       assertNotNull(peerTableId);
 
-      // Give our replication user the ability to write to the table
-      clientPeer.securityOperations().grantTablePermission(peerUserName, peerTable,
 
 Review comment:
   Is this present in the new changes?  If not, was it intentionally deleted?  I got kinda lost in the diff for this file.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services