DO NOT REPLY [Bug 40472] New: - SettingsManager calls loadSettings with global settings for Profilables

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=40472>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40472

           Summary: SettingsManager calls loadSettings with global settings
                    for Profilables
           Product: Log4j
           Version: unspecified
          Platform: All
        OS/Version: other
            Status: NEW
          Severity: normal
          Priority: P2
         Component: chainsaw
        AssignedTo: log4j-dev@logging.apache.org
        ReportedBy: silentmove@gmail.com


The chainsaw SettingsManager calls loadSettings(LoadSettingsEvent event) for 
classes implementing the Profilable interfaces from the loadGlobalSettings() 
method.
For these classes this isn't very useful, since at this time the 
LoadSettingsEvent doesn't contain profilable properties (they are loaded 
afterwards, in loadProfilableSettings().

Effectively, for classes implementing Profilable the 
loadSettings(LoadSettingsEvent event) method gets called twice:
- one time with global settings (which don't contain the needed properties, 
since Profilables need settings from the respective ~/.chainsaw/
<profilable>.properties file)
- a second time with global settings merged with properties gathered from the 
specific property-file in the ~/.chainsaw directory, now containing the needed 
properties

IMHO for Profilables the loadSettings(LoadSettingsEvent event) should be called 
only in the second call (where both global and specific properties are merged)

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org