You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/03/29 22:10:59 UTC
[GitHub] [solr] madrob opened a new pull request #774: SOLR-16125 Make tutorial commands copyable
madrob opened a new pull request #774:
URL: https://github.com/apache/solr/pull/774
https://issues.apache.org/jira/browse/SOLR-16125
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on a change in pull request #774: SOLR-16125 Make tutorial commands copyable
Posted by GitBox <gi...@apache.org>.
madrob commented on a change in pull request #774:
URL: https://github.com/apache/solr/pull/774#discussion_r838014493
##########
File path: solr/solr-ref-guide/modules/getting-started/pages/tutorial-films.adoc
##########
@@ -340,13 +352,13 @@ If we construct a query that looks like this:
[source,bash]
curl 'http://localhost:8983/solr/films/select?q=*:*&rows=0'\
- '&facet=true'\
- '&facet.range=initial_release_date'\
- '&facet.range.start=NOW-20YEAR'\
- '&facet.range.end=NOW'\
- '&facet.range.gap=%2B1YEAR'
+'&facet=true'\
+'&facet.range=initial_release_date'\
+'&facet.range.start=NOW/YEAR-25YEAR'\
+'&facet.range.end=NOW'\
+'&facet.range.gap=%2B1YEAR'
-This will request all films and ask for them to be grouped by year starting with 20 years ago (our earliest release date is in 2000) and ending today.
+This will request all films and ask for them to be grouped by year starting with 25 years ago (our earliest release date is in 2000) and ending today.
Review comment:
Because 20 years was no longer enough to cover the whole range (as it was when the tutorial was originally written, guessing 2015 or so)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob merged pull request #774: SOLR-16125 Make tutorial commands copyable
Posted by GitBox <gi...@apache.org>.
madrob merged pull request #774:
URL: https://github.com/apache/solr/pull/774
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] ctargett commented on pull request #774: SOLR-16125 Make tutorial commands copyable
Posted by GitBox <gi...@apache.org>.
ctargett commented on pull request #774:
URL: https://github.com/apache/solr/pull/774#issuecomment-1082500389
+1, IMO all examples should be in source blocks like this, so it's great to knock a couple out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on a change in pull request #774: SOLR-16125 Make tutorial commands copyable
Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #774:
URL: https://github.com/apache/solr/pull/774#discussion_r838152593
##########
File path: solr/solr-ref-guide/modules/getting-started/pages/tutorial-films.adoc
##########
@@ -340,13 +352,13 @@ If we construct a query that looks like this:
[source,bash]
curl 'http://localhost:8983/solr/films/select?q=*:*&rows=0'\
- '&facet=true'\
- '&facet.range=initial_release_date'\
- '&facet.range.start=NOW-20YEAR'\
- '&facet.range.end=NOW'\
- '&facet.range.gap=%2B1YEAR'
+'&facet=true'\
Review comment:
Ah, did not know that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on a change in pull request #774: SOLR-16125 Make tutorial commands copyable
Posted by GitBox <gi...@apache.org>.
madrob commented on a change in pull request #774:
URL: https://github.com/apache/solr/pull/774#discussion_r838014998
##########
File path: solr/solr-ref-guide/modules/getting-started/pages/tutorial-films.adoc
##########
@@ -340,13 +352,13 @@ If we construct a query that looks like this:
[source,bash]
curl 'http://localhost:8983/solr/films/select?q=*:*&rows=0'\
- '&facet=true'\
- '&facet.range=initial_release_date'\
- '&facet.range.start=NOW-20YEAR'\
- '&facet.range.end=NOW'\
- '&facet.range.gap=%2B1YEAR'
+'&facet=true'\
Review comment:
curl doesn't handle the whitespace indent when copy/pasting it, treats each set of `'&facet...` as a separate whitespace delimited argument. The `\` escapes the newline, but doesn't help with melding into a single arg.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on pull request #774: SOLR-16125 Make tutorial commands copyable
Posted by GitBox <gi...@apache.org>.
madrob commented on pull request #774:
URL: https://github.com/apache/solr/pull/774#issuecomment-1082420487
@janhoy I'd like to consider this for 9.0 to. improve user experience if somebody is coming to Solr for the first time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] anshumg commented on a change in pull request #774: SOLR-16125 Make tutorial commands copyable
Posted by GitBox <gi...@apache.org>.
anshumg commented on a change in pull request #774:
URL: https://github.com/apache/solr/pull/774#discussion_r837953151
##########
File path: solr/solr-ref-guide/modules/getting-started/pages/tutorial-films.adoc
##########
@@ -340,13 +352,13 @@ If we construct a query that looks like this:
[source,bash]
curl 'http://localhost:8983/solr/films/select?q=*:*&rows=0'\
- '&facet=true'\
- '&facet.range=initial_release_date'\
- '&facet.range.start=NOW-20YEAR'\
- '&facet.range.end=NOW'\
- '&facet.range.gap=%2B1YEAR'
+'&facet=true'\
+'&facet.range=initial_release_date'\
+'&facet.range.start=NOW/YEAR-25YEAR'\
+'&facet.range.end=NOW'\
+'&facet.range.gap=%2B1YEAR'
-This will request all films and ask for them to be grouped by year starting with 20 years ago (our earliest release date is in 2000) and ending today.
+This will request all films and ask for them to be grouped by year starting with 25 years ago (our earliest release date is in 2000) and ending today.
Review comment:
25 years should be 1997. Any specific reason you switched this to 25 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on a change in pull request #774: SOLR-16125 Make tutorial commands copyable
Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #774:
URL: https://github.com/apache/solr/pull/774#discussion_r837959011
##########
File path: solr/solr-ref-guide/modules/getting-started/pages/tutorial-films.adoc
##########
@@ -340,13 +352,13 @@ If we construct a query that looks like this:
[source,bash]
curl 'http://localhost:8983/solr/films/select?q=*:*&rows=0'\
- '&facet=true'\
- '&facet.range=initial_release_date'\
- '&facet.range.start=NOW-20YEAR'\
- '&facet.range.end=NOW'\
- '&facet.range.gap=%2B1YEAR'
+'&facet=true'\
Review comment:
Why no indent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org