You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by gkrishnan724 <gi...@git.apache.org> on 2016/10/27 12:34:52 UTC
[GitHub] incubator-fineract pull request #231: Better E-mail for new user
GitHub user gkrishnan724 opened a pull request:
https://github.com/apache/incubator-fineract/pull/231
Better E-mail for new user
[MIFOSX-2799]
When a new user is registered in community app, the email was complicated to understand.
Changed it to a more understandable way.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gkrishnan724/incubator-fineract MIFOSX-2799
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-fineract/pull/231.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #231
----
commit 2fef85ce4c3518be7ffff8dc2c86a35cb888e7bc
Author: gkrishnan724 <gk...@gmail.com>
Date: 2016-10-27T12:32:02Z
Better E-mail for new user
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract issue #231: Better E-mail for new user
Posted by gkrishnan724 <gi...@git.apache.org>.
Github user gkrishnan724 commented on the issue:
https://github.com/apache/incubator-fineract/pull/231
@nazeer1100126 I performed the changes using git commit --amend is it alright?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #231: Better E-mail for new user
Posted by gkrishnan724 <gi...@git.apache.org>.
Github user gkrishnan724 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/231#discussion_r88440592
--- Diff: fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/service/GmailBackedPlatformEmailService.java ---
@@ -57,18 +57,20 @@ public void sendToUserAccount(final EmailDetail emailDetail, final String unenco
}
email.setFrom(authuser, authuserName);
- final StringBuilder subjectBuilder = new StringBuilder().append("Fineract Prototype Demo: ").append(emailDetail.getContactName())
- .append(" user account creation.");
+ final StringBuilder subjectBuilder = new StringBuilder().append("Welcome ").append(emailDetail.getContactName())
--- End diff --
Okay, I'll do the changes :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract issue #231: Better E-mail for new user
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on the issue:
https://github.com/apache/incubator-fineract/pull/231
No, You need to send new PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #231: Better E-mail for new user
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/231#discussion_r88418573
--- Diff: fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/service/GmailBackedPlatformEmailService.java ---
@@ -57,18 +57,20 @@ public void sendToUserAccount(final EmailDetail emailDetail, final String unenco
}
email.setFrom(authuser, authuserName);
- final StringBuilder subjectBuilder = new StringBuilder().append("Fineract Prototype Demo: ").append(emailDetail.getContactName())
- .append(" user account creation.");
+ final StringBuilder subjectBuilder = new StringBuilder().append("Welcome ").append(emailDetail.getContactName())
--- End diff --
The subject line should be "New User Information" or 'Welcome to [Organization] Name'
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #231: Better E-mail for new user
Posted by gkrishnan724 <gi...@git.apache.org>.
Github user gkrishnan724 closed the pull request at:
https://github.com/apache/incubator-fineract/pull/231
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract issue #231: Better E-mail for new user
Posted by gkrishnan724 <gi...@git.apache.org>.
Github user gkrishnan724 commented on the issue:
https://github.com/apache/incubator-fineract/pull/231
Okay I will
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---