You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2018/12/16 14:09:27 UTC

[GitHub] RongtongJin opened a new pull request #610: [ISSUE #608] Polish the whole example module

RongtongJin opened a new pull request #610: [ISSUE #608] Polish the whole example module
URL: https://github.com/apache/rocketmq/pull/610
 
 
   ## What is the purpose of the change
   
   Polish the whole example module. Fix [issue608](https://github.com/apache/rocketmq/issues/608)
   
   ## Brief changelog
   
   #### example directory
   - batch (typo check)
      - SimpleBatchProducer.java 
      - SplitBatchProducer.java
   - benchmark (no change)
   - broadcast
      - BroadcastConsumer.java (renamed from PushConsumer.java, a clearer class name)
   - filter
      - SqlFilterConsumer.java (renamed from SqlConsumer.java, fix bug: missing “and” in SQL statement, add code comments )
      - SqlFilterProducer.java (renamed from SqlProducer.java, optimize code quality)
      - TagFilterConsumer.java (renamed from Consumer.java, changed from filtersrv example to tag filter example)
      - TagFilterProducer.java (renamed from Producer.java, changed from filtersrv example to tag filter example)
   - ordermessaging
      - OMSProducer.java (renamed from SimpleProducer.java)
      - OMSPullConsumer.java (renamed from SimplePullConsumer.java)
      - OMSPushConsumer.java (renamed from SimplePushConsumer.java)
   - operation (no change)
   - ordermessage
      - OrderedConsumer.java (renamed from Consumer.java, I thought the old code may confuse users, so I simplified the code logic and added more comments)
      - OrderedProducer.java (renamed from Producer.java, add code comments, change the messages keys' format to orderIDxx:xxth such as orderID6:8th for users to understand ordered messages better)
   - quickstart (no change)
   - sechedule (new package, show users how to send scheduled messages)
      - ScheduledMessageConsumer.java (new class)
      - ScheduledMessageProducer.java (new class)
   - simple
      - AsyncProducer.java (add code comments)
      - OnewayProducer.java (new class, show users how to send meassges in oneway)
      - PullConsumer.java 
      - PullScheduleService.java (no change)
      - PushConsumer.java (Setting ConsumeTimestamp is invalid when you set ConsumeFromWhere to CONSUME_FROM_FIRST_OFFSET, so I delete releated code)
      - QueryMsgByKey.java (renamed from TestProducer.java, a clearer class name)
      - SyncProducer.java (renamed from Producer.java)
      - ~~RandomAsyncCommit.java~~(remove this class. It doesn't show the users how to send or receive messages, and it also doesn't involve client code of RocketMQ)
      - ~~CachedQueue,java~~ (remove this class used in RandomAsyncCommit.java)
      - ~~PullConsumerTest.java~~ (remove this class. The code is similar to PullConsumer.java)
   - transaction (no change)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services