[GitHub] [superset] srinify commented on a change in pull request #19057: docs: add doc for maxcompute support

[GitBox <gi...@apache.org>]

srinify commented on a change in pull request #19057:
URL: https://github.com/apache/superset/pull/19057#discussion_r833177926



##########
File path: setup.py
##########
@@ -146,6 +146,7 @@ def get_git_sha() -> str:
         "impala": ["impyla>0.16.2, <0.17"],
         "kusto": ["sqlalchemy-kusto>=1.0.1, <2"],
         "kylin": ["kylinpy>=2.8.1, <2.9"],
+        "maxcompute": ["pyodps>=0.10"],

Review comment:
       This is a good start, but will only unlock some of the functionality between Maxcompute and Superset.
   
   Ideally, you can create a small, separate `db_engine_spec` just for maxcompute. Here's a quick example of one I made for CrateDB: https://github.com/apache/superset/blob/master/superset/db_engine_specs/crate.py#L32
   
   This will ensure for core features like:
   
   - Time grains (selection of day, week, month, etc) -> resulting in the correct SQL generation
   - Better experience in "Add Database" screen
   - Better support for timestamp & datetime values all around

##########
File path: docs/src/resources/data.js
##########
@@ -143,4 +143,9 @@ export const Databases = [
     href: "www.yugabyte.com",
     imgName: 'yugabyte.png'
   }

Review comment:
       Hey there, I think you're missing an extra comma here?
   
   https://github.com/apache/superset/runs/5546379868?check_suite_focus=true




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org