[GitHub] [iotdb] qiaojialin commented on a change in pull request #5363: [IOTDB-2811] Fix compaction exception handle failure cause by deletion of storage group

[GitBox <gi...@apache.org>]

qiaojialin commented on a change in pull request #5363:
URL: https://github.com/apache/iotdb/pull/5363#discussion_r839551753



##########
File path: server/src/main/java/org/apache/iotdb/db/engine/compaction/CompactionTaskManager.java
##########
@@ -290,35 +292,34 @@ public synchronized void removeRunningTaskFromList(AbstractCompactionTask task)
    *
    * @throws RejectedExecutionException
    */
-  public synchronized void submitTask(Callable<Void> compactionMergeTask)
+  public synchronized Future<Void> submitTask(AbstractCompactionTask compactionTask)

Review comment:
       The returned Future is not used anywhere.

##########
File path: server/src/main/java/org/apache/iotdb/db/engine/compaction/CompactionTaskManager.java
##########
@@ -64,8 +60,8 @@
       new FixedPriorityBlockingQueue<>(1024, new CompactionTaskComparator());
   // <logicalStorageGroupName,futureSet>, it is used to terminate all compaction tasks under the

Review comment:
       logicalstoragegroup-virtualstoragegroup=fullsgname




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org