common lisp support?

[james anderson <ja...@setf.de>]

good morning;

i note that there was a patch submitted for common lisp, but the jira  
issue is still open, and the code does not appear to be reflected in  
the latest release.

? what do you plan to do with the patch?
? would one expect it to work with the present release? with the  
current svn head?

thanks,

Re: common lisp support?

[james anderson <ja...@setf.de>]

good morning;

i started with the patch from the THRIFT-82 issue. i am keeping a  
github repository[1] up-to-date as i progress,

the code generator backend is a short extension from collison's  
version, but the lisp library is a rewrite.

please let me know about any things one might do differently -  
especially in the code generator.

my current application is work with cassandra. once it is stable -  
and once i can motivate someone to review the lisp code, i'l get back  
in touch.


On 2010-06-26, at 17:38 , David Reiss wrote:

>> i cannot say much about the c code, but i can review the lisp aspect.
>> would that help?
> Yes, but it looks like most of my feedback here
> (https://issues.apache.org/jira/browse/THRIFT-82) was on the code  
> generator.
>
> --David

[1]: http://github.com/lisp/de.setf.thrift

Re: common lisp support?

[David Reiss <dr...@facebook.com>]

> i cannot say much about the c code, but i can review the lisp aspect.
> would that help?
Yes, but it looks like most of my feedback here
(https://issues.apache.org/jira/browse/THRIFT-82) was on the code generator.

--David

Re: common lisp support?

[james anderson <ja...@setf.de>]

On 2010-06-26, at 06:31 , David Reiss wrote:

>> ? what do you plan to do with the patch?
> I asked for some changes, but they were never made.  If someone is  
> willing
> to take it through a few rounds of code review, we could definitely  
> commit it.

i cannot say much about the c code, but i can review the lisp aspect.
would that help?

>
>> ? would one expect it to work with the present release? with the  
>> current
>> svn head?
> Probably.  We haven't made too many changes to the parser and code  
> generation
> infrastructure.  If it doesn't work, you could probably use git  
> bisect to
> find the problem pretty easily.
>
> --David
>
> james anderson wrote:
>> good morning;
>>
>> i note that there was a patch submitted for common lisp, but the jira
>> issue is still open, and the code does not appear to be reflected  
>> in the
>> latest release.
>>
>> ? what do you plan to do with the patch?
>> ? would one expect it to work with the present release? with the  
>> current
>> svn head?
>>
>> thanks,
>>

Re: common lisp support?

[David Reiss <dr...@facebook.com>]

> ? what do you plan to do with the patch?
I asked for some changes, but they were never made.  If someone is willing
to take it through a few rounds of code review, we could definitely commit it.

> ? would one expect it to work with the present release? with the current
> svn head?
Probably.  We haven't made too many changes to the parser and code generation
infrastructure.  If it doesn't work, you could probably use git bisect to
find the problem pretty easily.

--David

james anderson wrote:
> good morning;
> 
> i note that there was a patch submitted for common lisp, but the jira
> issue is still open, and the code does not appear to be reflected in the
> latest release.
> 
> ? what do you plan to do with the patch?
> ? would one expect it to work with the present release? with the current
> svn head?
> 
> thanks,
>