You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by mi...@apache.org on 2016/03/26 01:16:11 UTC

lucene-solr:branch_6_0: fix bug in exception's message

Repository: lucene-solr
Updated Branches:
  refs/heads/branch_6_0 920bd0126 -> df7b4c3f5


fix bug in exception's message


Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/df7b4c3f
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/df7b4c3f
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/df7b4c3f

Branch: refs/heads/branch_6_0
Commit: df7b4c3f531ad644dce28a3280a2b116b7dda15c
Parents: 920bd01
Author: Mike McCandless <mi...@apache.org>
Authored: Fri Mar 25 20:15:07 2016 -0400
Committer: Mike McCandless <mi...@apache.org>
Committed: Fri Mar 25 20:16:11 2016 -0400

----------------------------------------------------------------------
 .../java/org/apache/lucene/search/PointRangeQuery.java |  2 +-
 .../org/apache/lucene/search/TestPointQueries.java     | 13 +++++++++++++
 2 files changed, 14 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/df7b4c3f/lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java
----------------------------------------------------------------------
diff --git a/lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java b/lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java
index eb183e2..4991096 100644
--- a/lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java
+++ b/lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java
@@ -72,7 +72,7 @@ public abstract class PointRangeQuery extends Query {
       throw new IllegalArgumentException("lowerPoint is not a fixed multiple of numDims");
     }
     if (lowerPoint.length != upperPoint.length) {
-      throw new IllegalArgumentException("lowerPoint has length=" + numDims + " but upperPoint has different length=" + upperPoint.length);
+      throw new IllegalArgumentException("lowerPoint has length=" + lowerPoint.length + " but upperPoint has different length=" + upperPoint.length);
     }
     this.numDims = numDims;
     this.bytesPerDim = lowerPoint.length / numDims;

http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/df7b4c3f/lucene/core/src/test/org/apache/lucene/search/TestPointQueries.java
----------------------------------------------------------------------
diff --git a/lucene/core/src/test/org/apache/lucene/search/TestPointQueries.java b/lucene/core/src/test/org/apache/lucene/search/TestPointQueries.java
index c2136c4..bc9ef75 100644
--- a/lucene/core/src/test/org/apache/lucene/search/TestPointQueries.java
+++ b/lucene/core/src/test/org/apache/lucene/search/TestPointQueries.java
@@ -2012,4 +2012,17 @@ public class TestPointQueries extends LuceneTestCase {
     other[2] = (byte) 5;
     assertFalse(q1.equals(BinaryPoint.newSetQuery("a", new byte[][] {zeros, other})));
   }
+
+  public void testInvalidPointLength() {
+    IllegalArgumentException e = expectThrows(IllegalArgumentException.class,
+                                              () -> {
+                                                new PointRangeQuery("field", new byte[4], new byte[8], 1) {
+                                                  @Override
+                                                  protected String toString(int dimension, byte[] value) {
+                                                    return "foo";
+                                                  }
+                                                };
+                                              });
+    assertEquals("lowerPoint has length=4 but upperPoint has different length=8", e.getMessage());
+  }
 }