[GitHub] incubator-brooklyn pull request: Class renames

[ahgittin <gi...@git.apache.org>]

GitHub user ahgittin opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/873

    Class renames

    Builds on #872 (which this incorporates):
    
    * adding a few more places to use the map when loading
    * doing a lookup based on the segment before `$` rather than an expensive map scan for any `startsWith`
    * refactoring so rename is supported in `Reflections` (which was doing many of the `loadClass` calls in any case)
    
    All renames get a debug log message of the form `Mapping <old> to <new>` .
    
    Have tested this with some 070-incubating serialized state, but more testing would be useful.
    
    Also have started a fine-tooth comb review of text/plan mentions of old classes, using a `grep -f <list> .../src` where `<list>` is the `awk { print $1 } | sort` of the `deserializedClassRenames.properties` map with blank lines removed; a bit more to come but wanted to get this out for review.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ahgittin/incubator-brooklyn class-renames

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/873.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #873
    
----
commit 3167af95c8ef25fa5bf787c34a73af2d7361b6bb
Author: Aled Sage <al...@gmail.com>
Date:   2015-08-30T11:03:01Z

    Handle class-renames in persisted state

commit be3e182a3a7b01859ac80f5f79dbe40558183c45
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date:   2015-08-31T08:05:42Z

    This closes #872

commit 9fca8a279c372088c99c5e120db35dd9c74c538c
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date:   2015-08-31T14:38:56Z

    Builds on #872 to add renamed-class checks in a few other places classes are loaded.
    
    Also tidies some error messages and adds a cache for renamed classes.

commit ce8010af762bdb6504dd4623c30e205d42fd96f3
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date:   2015-08-31T16:20:30Z

    rename some non-java mentions of classes which have been moved (e.g. in plans, or in comments)
    
    i've been through core with my regex; but other projects need a review!

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Class renames

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/873


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Class renames

[ahgittin <gi...@git.apache.org>]

Github user ahgittin commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/873#issuecomment-136754561
  
    As this is primarily a tidy-up of @aledsage 's work, plus doc tweaks, I'm going to merge this and update root docs and snapshot version docs on the site for comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---