You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Yan Fang <ya...@gmail.com> on 2015/08/05 01:07:04 UTC
Review Request 37102: SAMZA-753: BrokerProxy stop should shutdown
kafka consumer first
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37102/
-----------------------------------------------------------
Review request for samza.
Bugs: SAMZA-753
https://issues.apache.org/jira/browse/SAMZA-753
Repository: samza
Description
-------
shutdown the kafka consumer before interrupting the BrokerProxy
Diffs
-----
samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala 614f33f
Diff: https://reviews.apache.org/r/37102/diff/
Testing
-------
Thanks,
Yan Fang
Re: Review Request 37102: SAMZA-753: BrokerProxy stop should shutdown
kafka consumer first
Posted by Yan Fang <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37102/
-----------------------------------------------------------
(Updated Aug. 13, 2015, 1:12 a.m.)
Review request for samza.
Changes
-------
added unit test for the closing.
Bugs: SAMZA-753
https://issues.apache.org/jira/browse/SAMZA-753
Repository: samza
Description
-------
shutdown the kafka consumer before interrupting the BrokerProxy
Diffs (updated)
-----
samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala 614f33f
samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestBrokerProxy.scala e285dec
Diff: https://reviews.apache.org/r/37102/diff/
Testing
-------
Thanks,
Yan Fang
Re: Review Request 37102: SAMZA-753: BrokerProxy stop should shutdown
kafka consumer first
Posted by "Yi Pan (Data Infrastructure)" <yi...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37102/#review94146
-----------------------------------------------------------
Ship it!
This makes sense! Thanks Yan! Did you verify with some test? It would be good to verify it.
- Yi Pan (Data Infrastructure)
On Aug. 4, 2015, 11:07 p.m., Yan Fang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37102/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2015, 11:07 p.m.)
>
>
> Review request for samza.
>
>
> Bugs: SAMZA-753
> https://issues.apache.org/jira/browse/SAMZA-753
>
>
> Repository: samza
>
>
> Description
> -------
>
> shutdown the kafka consumer before interrupting the BrokerProxy
>
>
> Diffs
> -----
>
> samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala 614f33f
>
> Diff: https://reviews.apache.org/r/37102/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yan Fang
>
>