You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Colm O hEigeartaigh <co...@apache.org> on 2016/04/28 12:48:50 UTC
Review Request 46768: RANGER-958 - HDFS review
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46768/
-----------------------------------------------------------
Review request for ranger.
Repository: ranger
Description
-------
Some minor changes following a review of the HDFS code:
a) Remove unnecessary dependencies in both the HDFS shim + plugin
b) Some trivial changes to the RangerHdfsAuthorizer - use an empty Set for FS.NONE instead of creating a new Set + use an existing constructor for the RangerHdfsAccessRequest.
Diffs
-----
hdfs-agent/pom.xml f5e42eb
hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/RangerHdfsAuthorizer.java 93dca87
ranger-hdfs-plugin-shim/pom.xml 0522697
Diff: https://reviews.apache.org/r/46768/diff/
Testing
-------
Thanks,
Colm O hEigeartaigh
Re: Review Request 46768: RANGER-958 - HDFS review
Posted by Colm O hEigeartaigh <co...@apache.org>.
> On April 28, 2016, 1:54 p.m., Madhan Neethiraj wrote:
> > Colm - can you please confirm that the HDFS plugin generated with this update works without running into any issues? If you verified this, the patch is good to go. Thanks.
Hi Madhan, I've just simplified the patch to remove unnecessary dependencies from the HDFS plugin. I've verified that the same jars are present in the HDFS plugin archive as before the patch, so it has 0 impact on the generated plugin. Please review + I will then commit.
- Colm
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46768/#review130915
-----------------------------------------------------------
On April 28, 2016, 10:48 a.m., Colm O hEigeartaigh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46768/
> -----------------------------------------------------------
>
> (Updated April 28, 2016, 10:48 a.m.)
>
>
> Review request for ranger.
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Some minor changes following a review of the HDFS code:
>
> a) Remove unnecessary dependencies in both the HDFS shim + plugin
> b) Some trivial changes to the RangerHdfsAuthorizer - use an empty Set for FS.NONE instead of creating a new Set + use an existing constructor for the RangerHdfsAccessRequest.
>
>
> Diffs
> -----
>
> hdfs-agent/pom.xml f5e42eb
> hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/RangerHdfsAuthorizer.java 93dca87
> ranger-hdfs-plugin-shim/pom.xml 0522697
>
> Diff: https://reviews.apache.org/r/46768/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colm O hEigeartaigh
>
>
Re: Review Request 46768: RANGER-958 - HDFS review
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46768/#review130915
-----------------------------------------------------------
Colm - can you please confirm that the HDFS plugin generated with this update works without running into any issues? If you verified this, the patch is good to go. Thanks.
- Madhan Neethiraj
On April 28, 2016, 10:48 a.m., Colm O hEigeartaigh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46768/
> -----------------------------------------------------------
>
> (Updated April 28, 2016, 10:48 a.m.)
>
>
> Review request for ranger.
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Some minor changes following a review of the HDFS code:
>
> a) Remove unnecessary dependencies in both the HDFS shim + plugin
> b) Some trivial changes to the RangerHdfsAuthorizer - use an empty Set for FS.NONE instead of creating a new Set + use an existing constructor for the RangerHdfsAccessRequest.
>
>
> Diffs
> -----
>
> hdfs-agent/pom.xml f5e42eb
> hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/RangerHdfsAuthorizer.java 93dca87
> ranger-hdfs-plugin-shim/pom.xml 0522697
>
> Diff: https://reviews.apache.org/r/46768/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colm O hEigeartaigh
>
>
Re: Review Request 46768: RANGER-958 - HDFS dependency review
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46768/
-----------------------------------------------------------
(Updated Aug. 8, 2016, 6:03 p.m.)
Review request for ranger.
Summary (updated)
-----------------
RANGER-958 - HDFS dependency review
Bugs: RANGER-958
https://issues.apache.org/jira/browse/RANGER-958
Repository: ranger
Description (updated)
-------
The HDFS plugin has a bunch of unused dependencies defined in the pom.
Diffs (updated)
-----
hdfs-agent/pom.xml 716d43e
Diff: https://reviews.apache.org/r/46768/diff/
Testing
-------
Thanks,
Colm O hEigeartaigh