You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "ZhengLin-Li (via GitHub)" <gi...@apache.org> on 2024/02/19 17:51:16 UTC
[PR] Update DISCLAIMER (eventmesh)
ZhengLin-Li opened a new pull request, #4775:
URL: https://github.com/apache/eventmesh/pull/4775
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
- Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Closes #<XXX>`.)
-->
Fixes https://github.com/apache/eventmesh/issues/4718
### Motivation
EventMesh is no longer in incubator
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE #4718] Update DISCLAIMER (eventmesh)
Posted by "ZhengLin-Li (via GitHub)" <gi...@apache.org>.
ZhengLin-Li commented on code in PR #4775:
URL: https://github.com/apache/eventmesh/pull/4775#discussion_r1500965134
##########
DISCLAIMER:
##########
@@ -1,11 +1,5 @@
-Apache EventMesh is an effort undergoing incubation at The Apache Software Foundation (ASF),
-sponsored by the Apache Incubator PMC.
-
-Incubation is required of all newly accepted projects until a further review indicates that the infrastructure,
-communications, and decision-making process have stabilized in a manner consistent with other successful ASF projects.
-
-While incubation status is not necessarily a reflection of the completeness or stability of the code,
-it does indicate that the project has yet to be fully endorsed by the ASF.
+Apache EventMesh, previously incubating at The Apache Software Foundation (ASF)
+has successfully graduated from the incubator phase.
Review Comment:
I noticed that not many Apache projects have a DISCLAIMER file.
Actually, I searched about 15 Apache Incubater graduate projects, and none of them have a DISCLAIMER file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4718] Update DISCLAIMER (eventmesh)
Posted by "mxsm (via GitHub)" <gi...@apache.org>.
mxsm merged PR #4775:
URL: https://github.com/apache/eventmesh/pull/4775
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE #4718] Update DISCLAIMER (eventmesh)
Posted by "ZhengLin-Li (via GitHub)" <gi...@apache.org>.
ZhengLin-Li commented on code in PR #4775:
URL: https://github.com/apache/eventmesh/pull/4775#discussion_r1500965134
##########
DISCLAIMER:
##########
@@ -1,11 +1,5 @@
-Apache EventMesh is an effort undergoing incubation at The Apache Software Foundation (ASF),
-sponsored by the Apache Incubator PMC.
-
-Incubation is required of all newly accepted projects until a further review indicates that the infrastructure,
-communications, and decision-making process have stabilized in a manner consistent with other successful ASF projects.
-
-While incubation status is not necessarily a reflection of the completeness or stability of the code,
-it does indicate that the project has yet to be fully endorsed by the ASF.
+Apache EventMesh, previously incubating at The Apache Software Foundation (ASF)
+has successfully graduated from the incubator phase.
Review Comment:
I noticed that not many apache projects have DISCLAIMER file,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4718] Update DISCLAIMER (eventmesh)
Posted by "ZhengLin-Li (via GitHub)" <gi...@apache.org>.
ZhengLin-Li commented on code in PR #4775:
URL: https://github.com/apache/eventmesh/pull/4775#discussion_r1528889704
##########
DISCLAIMER:
##########
@@ -1,11 +1,5 @@
-Apache EventMesh is an effort undergoing incubation at The Apache Software Foundation (ASF),
-sponsored by the Apache Incubator PMC.
-
-Incubation is required of all newly accepted projects until a further review indicates that the infrastructure,
-communications, and decision-making process have stabilized in a manner consistent with other successful ASF projects.
-
-While incubation status is not necessarily a reflection of the completeness or stability of the code,
-it does indicate that the project has yet to be fully endorsed by the ASF.
+Apache EventMesh, previously incubating at The Apache Software Foundation (ASF)
+has successfully graduated from the incubator phase.
Review Comment:
> A podling project must include a disclaimer in its repo, and a TLP doesn't have a disclaimer policy according to https://incubator.apache.org/policy/incubation.html#disclaimers. So you can just delete this file.
sure, thanks for you guidance. then i will delete this file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] Update DISCLAIMER (eventmesh)
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on PR #4775:
URL: https://github.com/apache/eventmesh/pull/4775#issuecomment-1954183622
By the way, please standardize the PR title.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4718] Update DISCLAIMER (eventmesh)
Posted by "ZhengLin-Li (via GitHub)" <gi...@apache.org>.
ZhengLin-Li commented on code in PR #4775:
URL: https://github.com/apache/eventmesh/pull/4775#discussion_r1500965134
##########
DISCLAIMER:
##########
@@ -1,11 +1,5 @@
-Apache EventMesh is an effort undergoing incubation at The Apache Software Foundation (ASF),
-sponsored by the Apache Incubator PMC.
-
-Incubation is required of all newly accepted projects until a further review indicates that the infrastructure,
-communications, and decision-making process have stabilized in a manner consistent with other successful ASF projects.
-
-While incubation status is not necessarily a reflection of the completeness or stability of the code,
-it does indicate that the project has yet to be fully endorsed by the ASF.
+Apache EventMesh, previously incubating at The Apache Software Foundation (ASF)
+has successfully graduated from the incubator phase.
Review Comment:
I noticed that not many Apache projects have a DISCLAIMER file. Actually, I searched about 15 Apache projects, and none of them have a DISCLAIMER file.
So, what will we do next? 🤣🤣🤣
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4718] Update DISCLAIMER (eventmesh)
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on code in PR #4775:
URL: https://github.com/apache/eventmesh/pull/4775#discussion_r1501360316
##########
DISCLAIMER:
##########
@@ -1,11 +1,5 @@
-Apache EventMesh is an effort undergoing incubation at The Apache Software Foundation (ASF),
-sponsored by the Apache Incubator PMC.
-
-Incubation is required of all newly accepted projects until a further review indicates that the infrastructure,
-communications, and decision-making process have stabilized in a manner consistent with other successful ASF projects.
-
-While incubation status is not necessarily a reflection of the completeness or stability of the code,
-it does indicate that the project has yet to be fully endorsed by the ASF.
+Apache EventMesh, previously incubating at The Apache Software Foundation (ASF)
+has successfully graduated from the incubator phase.
Review Comment:
A podling project must include a disclaimer in its repo, and a TLP doesn't have a disclaimer policy according to https://incubator.apache.org/policy/incubation.html#disclaimers. So you can just delete this file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4718] Update DISCLAIMER (eventmesh)
Posted by "ZhengLin-Li (via GitHub)" <gi...@apache.org>.
ZhengLin-Li commented on PR #4775:
URL: https://github.com/apache/eventmesh/pull/4775#issuecomment-2004408318
hi @Pil0tXia thanks for your review, i have updated the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4718] Update DISCLAIMER (eventmesh)
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on code in PR #4775:
URL: https://github.com/apache/eventmesh/pull/4775#discussion_r1501361198
##########
DISCLAIMER:
##########
@@ -1,11 +1,5 @@
-Apache EventMesh is an effort undergoing incubation at The Apache Software Foundation (ASF),
-sponsored by the Apache Incubator PMC.
-
-Incubation is required of all newly accepted projects until a further review indicates that the infrastructure,
-communications, and decision-making process have stabilized in a manner consistent with other successful ASF projects.
-
-While incubation status is not necessarily a reflection of the completeness or stability of the code,
-it does indicate that the project has yet to be fully endorsed by the ASF.
+Apache EventMesh, previously incubating at The Apache Software Foundation (ASF)
+has successfully graduated from the incubator phase.
Review Comment:
The word DISCLAIMER also appears twice in the `.licenserc.yaml` file and can be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] Update DISCLAIMER (eventmesh)
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on code in PR #4775:
URL: https://github.com/apache/eventmesh/pull/4775#discussion_r1495265132
##########
DISCLAIMER:
##########
@@ -1,11 +1,5 @@
-Apache EventMesh is an effort undergoing incubation at The Apache Software Foundation (ASF),
-sponsored by the Apache Incubator PMC.
-
-Incubation is required of all newly accepted projects until a further review indicates that the infrastructure,
-communications, and decision-making process have stabilized in a manner consistent with other successful ASF projects.
-
-While incubation status is not necessarily a reflection of the completeness or stability of the code,
-it does indicate that the project has yet to be fully endorsed by the ASF.
+Apache EventMesh, previously incubating at The Apache Software Foundation (ASF)
+has successfully graduated from the incubator phase.
Review Comment:
You may take other apache project's DISCLAIMER file as a reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4718] Update DISCLAIMER (eventmesh)
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #4775:
URL: https://github.com/apache/eventmesh/pull/4775#issuecomment-2006397472
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/4775?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 16.34%. Comparing base [(`9a3912a`)](https://app.codecov.io/gh/apache/eventmesh/commit/9a3912a35b1dab6d77d6218fac926ac88c28e2bf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`3d040de`)](https://app.codecov.io/gh/apache/eventmesh/pull/4775?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 7 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #4775 +/- ##
============================================
- Coverage 16.37% 16.34% -0.03%
- Complexity 1734 1735 +1
============================================
Files 856 856
Lines 31265 31244 -21
Branches 2701 2698 -3
============================================
- Hits 5120 5108 -12
+ Misses 25665 25658 -7
+ Partials 480 478 -2
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/eventmesh/pull/4775?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org