[GitHub] [maven-gpg-plugin] Tibor17 commented on a change in pull request #11: [MGPG-81] check format in constructor

[GitBox <gi...@apache.org>]

Tibor17 commented on a change in pull request #11:
URL: https://github.com/apache/maven-gpg-plugin/pull/11#discussion_r627307690



##########
File path: src/main/java/org/apache/maven/plugins/gpg/GpgVersion.java
##########
@@ -32,54 +32,46 @@
  */
 public class GpgVersion implements Comparable<GpgVersion>
 {
-    private final String rawVersion;
 
-    private GpgVersion( String rawVersion )
-    {
-        this.rawVersion = rawVersion;
-    }
+    private static final Pattern VERSION_PATTERN = Pattern.compile( "(\\d+\\.)+(\\d+)" );

Review comment:
       @Syquel 
   @elharo 
   How many times these patterns exist in the project?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org