You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/17 19:23:53 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #823:
Config
xiaoxiang781216 opened a new pull request #823: Config
URL: https://github.com/apache/incubator-nuttx/pull/823
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo merged pull request #823: Run
refresh.sh for all config
Posted by GitBox <gi...@apache.org>.
patacongo merged pull request #823: Run refresh.sh for all config
URL: https://github.com/apache/incubator-nuttx/pull/823
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request
#823: Run refresh.sh for all config
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #823: Run refresh.sh for all config
URL: https://github.com/apache/incubator-nuttx/pull/823#discussion_r410697324
##########
File path: boards/x86_64/intel64/qemu-intel64/configs/ostest/defconfig
##########
@@ -1,114 +1,53 @@
#
-# Automatically generated file; DO NOT EDIT.
-# Nuttx/x86_64 Configuration
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
#
Review comment:
A lot of changes to this defconfig. This means that it was probably hand editted. Running refresh.sh on hand-edited defconfig files usually breaks them because a human is not capable of keeping all of the dependencies in their head.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #823: Run refresh.sh
for all config
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #823: Run refresh.sh for all config
URL: https://github.com/apache/incubator-nuttx/pull/823#issuecomment-615468409
The PR check failure looks like a real failure:
arm-none-eabi-ld: /github/workspace/nuttx/arch/arm/src/board/libboard.a(cxd56_bringup.o): in function `cxd56_bringup':
/github/workspace/nuttx/boards/arm/cxd56xx/common/board/cxd56_bringup.c:362: undefined reference to `isx012_initialize'
arm-none-eabi-ld: /github/workspace/nuttx/arch/arm/src/board/libboard.a(cxd56_isx012.o): in function `board_isx012_initialize':
/github/workspace/nuttx/boards/arm/cxd56xx/common/src/cxd56_isx012.c:216: undefined reference to `isx012_register'
I am not sure how the config changes could have caused this(?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] Ouss4 commented on issue #823: Run refresh.sh for
all config
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on issue #823: Run refresh.sh for all config
URL: https://github.com/apache/incubator-nuttx/pull/823#issuecomment-615485750
> I am not sure how the config changes could have caused this(?)
The config Xiang added made some code reference functions from the `isx012.c` file. However there is a typo in a cxd56 board make.defs, that file is not brought to the build.
```make
ifeq ($(VIDEO_ISX012),y) # CONFIG_ is missing
CSRCS += isx012.c
endif
```
File in question: boards/arm/cxd56xx/drivers/camera/Make.defs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #823: Run
refresh.sh for all config
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #823: Run refresh.sh for all config
URL: https://github.com/apache/incubator-nuttx/pull/823#issuecomment-615845027
> > I am not sure how the config changes could have caused this(?)
>
> The config Xiang added made some code reference functions from the `isx012.c` file. However there is a typo in a cxd56 board make.defs, that file is not brought to the build.
>
> ```makefile
> ifeq ($(VIDEO_ISX012),y) # CONFIG_ is missing
> CSRCS += isx012.c
> endif
> ```
>
> File in question: boards/arm/cxd56xx/drivers/camera/Make.defs
Good finding, I will create a PR fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services