You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/03/07 18:31:12 UTC
[GitHub] [nifi] exceptionfactory commented on a change in pull request #5845: NIFI-9768: Fix indeterminate map ordering in testSchemaToAttribute
exceptionfactory commented on a change in pull request #5845:
URL: https://github.com/apache/nifi/pull/5845#discussion_r820986661
##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AttributesToCSV.java
##########
@@ -288,7 +290,9 @@ public void onTrigger(ProcessContext context, ProcessSession session) throws Pro
}
final Set<String> attributeList = attributeListStringToSet(context.getProperty(ATTRIBUTES_LIST).evaluateAttributeExpressions(original).getValue());
+ System.out.println("****************** attributeList " + attributeList.getClass());
final Map<String, String> atrList = buildAttributesMapForFlowFile(original, attributeList, pattern);
+ System.out.println("****************** atrList " + atrList.getClass());
Review comment:
```suggestion
```
##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AttributesToCSV.java
##########
@@ -288,7 +290,9 @@ public void onTrigger(ProcessContext context, ProcessSession session) throws Pro
}
final Set<String> attributeList = attributeListStringToSet(context.getProperty(ATTRIBUTES_LIST).evaluateAttributeExpressions(original).getValue());
+ System.out.println("****************** attributeList " + attributeList.getClass());
Review comment:
`System.out.println()` should not be used.
```suggestion
```
##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AttributesToCSV.java
##########
@@ -230,6 +230,8 @@ protected void init(final ProcessorInitializationContext context) {
//now glue on the core attributes if the user wants them.
if(includeCoreAttributes) {
for (String coreAttribute : coreAttributes) {
+ System.out.println("****************** " + coreAttributes.getClass());
+ System.out.println(coreAttribute);
Review comment:
`System.out.println()` should not be used.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org