You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/11/03 14:10:20 UTC

[GitHub] [kafka] ivanyu commented on a change in pull request #6820: MINOR: move connectorConfig to AbstractHerder

ivanyu commented on a change in pull request #6820:
URL: https://github.com/apache/kafka/pull/6820#discussion_r516447945



##########
File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java
##########
@@ -751,14 +751,8 @@ public Void call() throws Exception {
 
     @Override
     public void connectorConfig(String connName, final Callback<Map<String, String>> callback) {
-        // Subset of connectorInfo, so piggy back on that implementation
         log.trace("Submitting connector config read request {}", connName);

Review comment:
       The trace logging for other operations (`putConnectorConfig`, `taskConfigs`, etc) is done only in `DistributedHerder`, too. For the consistency sake, I'd leave it as is in this PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org