[jira] Updated: (HADOOP-5358) Provide scripting functionality to the synthetic load generator

["Jakob Homan (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HADOOP-5358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jakob Homan updated HADOOP-5358:
--------------------------------

    Attachment: HADOOP-5358.patch

Updated to address Hairong's comments.

bq. when -scriptFile is specified, makes sure that neither rp, wp, nor ealspsed time is specified.
Done.  Now will half if any combination of command-line params and script file are passed.

bq. should put file close in finally to make the script file is closed even if errors occur when reading the file;
Good catch.  Done.
bq. better check the validity of read and write probabilities (r+w should smaller than 1) while reading the script file so no need to continue reading if there is an invalid parameter.
Moved all of the param checking code into one method and now call that method in both sections.  Cleaner this way, if command-line parsing code can every be considered clean.
bq. could use List.toArray to do the array conversion;
Unfortunately, toArray doesn't play well with value types, so I can't.
bq. what if the script file contains no valid lines
Added check that we get at least one valid line from script.

Thanks for the review.

> Provide scripting functionality to the synthetic load generator
> ---------------------------------------------------------------
>
>                 Key: HADOOP-5358
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5358
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: test
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>            Priority: Minor
>         Attachments: HADOOP-5358.patch, HADOOP-5358.patch
>
>
> Currently the load generator accepts parameters at start time as to the read and write probabilities to apply against the namenode.  It would be useful to be able to provide it with a script of these values, so that they can be varied over time.  This would allow the namenode to be tested with varying loads over time so its behavior to changing loads can be examined.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.