You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@usergrid.apache.org by snoopdave <gi...@git.apache.org> on 2015/06/18 17:16:54 UTC

[GitHub] incubator-usergrid pull request: Fix test problems and re-enable A...

GitHub user snoopdave opened a pull request:

    https://github.com/apache/incubator-usergrid/pull/287

    Fix test problems and re-enable AssetResourceIT tests

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-usergrid USERGRID=745

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-usergrid/pull/287.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #287
    
----
commit 47db44c8930f91dc9aa77eb3142b6a8da3f57e37
Author: Dave Johnson <dm...@apigee.com>
Date:   2015-06-18T15:15:48Z

    Fix test problems and re-enable AssetResourceIT tests.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-usergrid pull request: Fix test problems and re-enable A...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-usergrid/pull/287


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-usergrid pull request: Fix test problems and re-enable A...

Posted by shawnfeldman <gi...@git.apache.org>.
Github user shawnfeldman commented on a diff in the pull request:

    https://github.com/apache/incubator-usergrid/pull/287#discussion_r32743261
  
    --- Diff: stack/rest/src/test/java/org/apache/usergrid/rest/applications/assets/AssetResourceIT.java ---
    @@ -111,8 +109,10 @@ public void octetStreamOnDynamicEntity() throws Exception {
     
             String orgAppPath = clientSetup.getOrganizationName() + "/" + clientSetup.getAppName();
     
    -        JsonNode node = mapper.readTree( resource().path( orgAppPath + "/foos" ).queryParam( "access_token", access_token )
    -            .accept( MediaType.APPLICATION_JSON ).type( MediaType.APPLICATION_JSON_TYPE )
    +        JsonNode node = mapper.readTree( resource().path( orgAppPath + "/foos" )
    --- End diff --
    
    should convert this to new structure if possible, conversion is pretty straightforward


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---