[jira] [Resolved] (WICKET-6260) Revert Ajax detection needed for character encoding to WebRequest.isAjax()

["Sven Meier (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WICKET-6260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sven Meier resolved WICKET-6260.
--------------------------------
       Resolution: Fixed
    Fix Version/s: 8.0.0-M3
                   7.6.0
                   6.26

WebRequest#isAjax() is queried again now.

> Revert Ajax detection needed for character encoding to WebRequest.isAjax()
> --------------------------------------------------------------------------
>
>                 Key: WICKET-6260
>                 URL: https://issues.apache.org/jira/browse/WICKET-6260
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 8.0.0-M2, 6.25.0, 7.5.0
>            Reporter: Sven Meier
>            Assignee: Sven Meier
>            Priority: Minor
>             Fix For: 6.26, 7.6.0, 8.0.0-M3
>
>
> This issue has some history:
> - with WICKET-3908 the character encoding became dependent on whether the request is sent via Ajax
> - with WICKET-3914 the Ajax check was limited to the request header, preventing body parameters being read before the character encoding was set
> - since WICKET-6135 WebRequest.isAjax() no longer accesses body parameters.
> Thus I conclude that we can safely revert the changes of WICKET-3914 and just use WebRequest.isAjax() again in WebApplication.createWebRequest().
> Benefits:
> - removes duplicated logic in WebApplication.createWebRequest()
> - allows WebRequest to identify Ajax request by different means (as advertised in the Javadoc of #isAjax())
> - makes WICKET-6144 effective for all access to the 'Wicket-Ajax' header/parameter



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)