You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Richard Zang <rz...@hortonworks.com> on 2014/11/19 01:41:37 UTC
Review Request 28199: Quick Links should be disabled when the service
is down.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28199/
-----------------------------------------------------------
Review request for Ambari, Jaimin Jetly and Yusaku Sako.
Bugs: AMBARI-8380
https://issues.apache.org/jira/browse/AMBARI-8380
Repository: ambari
Description
-------
When the service is down, quick links should be disabled. Otherwise the link is taking to 404 page.
Diffs
-----
ambari-web/app/controllers/main/service/item.js 2666032
ambari-web/app/templates/main/service/item.hbs a264f5f
ambari-web/app/views/common/quick_view_link_view.js 4123c8f
Diff: https://reviews.apache.org/r/28199/diff/
Testing
-------
Manually tested on a live cluster.
Thanks,
Richard Zang
Re: Review Request 28199: Quick Links should be disabled when the
service is down.
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28199/#review62092
-----------------------------------------------------------
This would disable QuickLinks altogether for the entire service if any of its master component is down.
Instead of disabling the whole QuickLinks at the service-level, we should disable at the individual link level and say "<UI link name> (Inaccessible)" or something to that effect.
- Yusaku Sako
On Nov. 19, 2014, 12:41 a.m., Richard Zang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28199/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2014, 12:41 a.m.)
>
>
> Review request for Ambari, Jaimin Jetly and Yusaku Sako.
>
>
> Bugs: AMBARI-8380
> https://issues.apache.org/jira/browse/AMBARI-8380
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When the service is down, quick links should be disabled. Otherwise the link is taking to 404 page.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/service/item.js 2666032
> ambari-web/app/templates/main/service/item.hbs a264f5f
> ambari-web/app/views/common/quick_view_link_view.js 4123c8f
>
> Diff: https://reviews.apache.org/r/28199/diff/
>
>
> Testing
> -------
>
> Manually tested on a live cluster.
>
>
> Thanks,
>
> Richard Zang
>
>