[GitHub] [pulsar] 315157973 commented on a change in pull request #8474: Support taking de-duplication snapshots based on time

[GitBox <gi...@apache.org>]

315157973 commented on a change in pull request #8474:
URL: https://github.com/apache/pulsar/pull/8474#discussion_r519355600



##########
File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -413,6 +413,18 @@
     )
     private int brokerDeduplicationMaxNumberOfProducers = 10000;
 
+    @FieldContext(
+        category = CATEGORY_POLICIES,
+        doc = "How often is the thread pool scheduled to check whether a snapshot needs to be taken.(disable with value 0)"
+    )
+    private int brokerDeduplicationSnapshotFrequencyInSeconds = 120;
+    @FieldContext(
+        category = CATEGORY_POLICIES,
+        doc = "If this time interval is exceeded, a snapshot will be taken."
+            + "It will run simultaneously with `brokerDeduplicationEntriesInterval`"
+    )
+    private Integer brokerDeduplicationSnapshotIntervalSeconds = 120;

Review comment:
       Later, we need to support the namespace-level and topic-level. When it is null, it means that this level is not set. Therefore the packaging type is used.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org