You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by mg...@apache.org on 2013/02/07 10:23:54 UTC
[1/2] git commit: JSDoc improvements
JSDoc improvements
No functional changes
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/474667c1
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/474667c1
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/474667c1
Branch: refs/heads/master
Commit: 474667c172955d722a7b6542838cdbe0355dbd67
Parents: 1fa1094
Author: Martin Tzvetanov Grigorov <mg...@apache.org>
Authored: Thu Feb 7 10:22:17 2013 +0100
Committer: Martin Tzvetanov Grigorov <mg...@apache.org>
Committed: Thu Feb 7 10:22:17 2013 +0100
----------------------------------------------------------------------
.../wicket/ajax/res/js/wicket-ajax-jquery.js | 14 ++++++++++++--
wicket-core/src/test/js/all.html | 2 +-
2 files changed, 13 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/wicket/blob/474667c1/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js b/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
index 358dd31..71d10fb 100644
--- a/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
+++ b/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
@@ -322,6 +322,14 @@
initialize: jQuery.noop,
+ /**
+ * Initializes the default values for Ajax request attributes.
+ * The defaults are not set at the server side to save some bytes
+ * for the network transfer
+ *
+ * @param attrs {Object} - the ajax request attributes to enrich
+ * @private
+ */
_initializeDefaults: function (attrs) {
// (ajax channel)
@@ -359,7 +367,8 @@
/**
* A helper function that executes an array of handlers (before, success, failure)
*
- * @param handlers {Array[FunctionBody]} - the handlers to execute
+ * @param handlers {Array[Function]} - the handlers to execute
+ * @private
*/
_executeHandlers: function (handlers) {
if (jQuery.isArray(handlers)) {
@@ -386,6 +395,7 @@
* name -> value pairs.
* @see jQuery.param
* @see jQuery.serializeArray
+ * @private
*/
_asParamArray: function(parameters) {
var result = [],
@@ -441,7 +451,7 @@
self = this,
// the precondition to use if there are no explicit ones
- defaultPrecondition = [ function (attributes, jqXHR, jqSettings) {
+ defaultPrecondition = [ function (attributes) {
if (attributes.c) {
if (attributes.f) {
return Wicket.$$(attributes.c) && Wicket.$$(attributes.f);
http://git-wip-us.apache.org/repos/asf/wicket/blob/474667c1/wicket-core/src/test/js/all.html
----------------------------------------------------------------------
diff --git a/wicket-core/src/test/js/all.html b/wicket-core/src/test/js/all.html
index c4e90c4..07fc403 100644
--- a/wicket-core/src/test/js/all.html
+++ b/wicket-core/src/test/js/all.html
@@ -1,5 +1,5 @@
<!DOCTYPE html>
-<html xmlns:wicket="http://wicket.apache.org">
+<html>
<head>
<title id="titleId">All tests</title>