[GitHub] [hudi] xiarixiaoyao commented on a diff in pull request #6589: [HUDI-4776] fix merge into use unresolved assignment

[GitBox <gi...@apache.org>]

xiarixiaoyao commented on code in PR #6589:
URL: https://github.com/apache/hudi/pull/6589#discussion_r963371473


##########
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/analysis/HoodieAnalysis.scala:
##########
@@ -282,13 +282,21 @@ case class HoodieResolveReferences(sparkSession: SparkSession) extends Rule[Logi
           // the hoodie's meta field in sql statement, it is a system field, cannot set the value
           // by user.
           if (HoodieSparkUtils.isSpark3) {
-            val assignmentFieldNames = assignments.map(_.key).map {
+            val resolvedAssignments = assignments.map { assign =>

Review Comment:
   
   if spark have not resolve *， assignments will be empty ？ so maybe we have no need to resolve all assignments here。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org